Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qsstv: init 9.2.6 #44323

Merged
merged 2 commits into from Aug 18, 2018
Merged

qsstv: init 9.2.6 #44323

merged 2 commits into from Aug 18, 2018

Conversation

hax404
Copy link
Contributor

@hax404 hax404 commented Aug 1, 2018

Motivation for this change

I want to add this program that is useful for amateur radio operators.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Aug 2, 2018
View reviewed changes
pkgs/applications/misc/qsstv/default.nix Outdated
make INSTALL_ROOT=$out install
install -D ${./qsstv.desktop} $out/share/applications/qsstv.desktop
install -D qsstv/icons/qsstv.png $out/usr/share/pixmaps/qsstv.png
substituteAll ${./qsstv.desktop} $out/share/applications/qsstv.desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we use makeDesktopItem for new packages.

desktopItem = makeDesktopItem {
  name = "eduke32";
  exec = "eduke32-wrapper";
  comment = "Duke Nukem 3D port";
  desktopName = "Enhanced Duke Nukem 3D";
  genericName = "Duke Nukem 3D port";
  categories = "Application;Game;";
};

See also pkgs/games/eduke32/default.nix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this information. I changed the files accordingly.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build qsstv

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: qsstv

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: qsstv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/c9lzgc9nrjhh9522ci6liimmyalv983q-qsstv-9.2.6
shrinking /nix/store/c9lzgc9nrjhh9522ci6liimmyalv983q-qsstv-9.2.6/bin/qsstv
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/c9lzgc9nrjhh9522ci6liimmyalv983q-qsstv-9.2.6/bin
patching script interpreter paths in /nix/store/c9lzgc9nrjhh9522ci6liimmyalv983q-qsstv-9.2.6
checking for references to /build in /nix/store/c9lzgc9nrjhh9522ci6liimmyalv983q-qsstv-9.2.6...
postPatchMkspecs
postPatchMkspecs
/nix/store/c9lzgc9nrjhh9522ci6liimmyalv983q-qsstv-9.2.6

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: qsstv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1qwkqcv0z3y5niby0hm2px9j57k555mj-qsstv-9.2.6
shrinking /nix/store/1qwkqcv0z3y5niby0hm2px9j57k555mj-qsstv-9.2.6/bin/qsstv
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1qwkqcv0z3y5niby0hm2px9j57k555mj-qsstv-9.2.6/bin
patching script interpreter paths in /nix/store/1qwkqcv0z3y5niby0hm2px9j57k555mj-qsstv-9.2.6
checking for references to /build in /nix/store/1qwkqcv0z3y5niby0hm2px9j57k555mj-qsstv-9.2.6...
postPatchMkspecs
postPatchMkspecs
/nix/store/1qwkqcv0z3y5niby0hm2px9j57k555mj-qsstv-9.2.6

@Mic92 Mic92 merged commit b9fafcf into NixOS:master Aug 18, 2018
@hax404 hax404 deleted the add/qsstv branch February 7, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hax404 @matthewbauer @GrahamcOfBorg @Mic92 @Janik-Haag