Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Studio improvements #44310

Merged
merged 4 commits into from Aug 1, 2018
Merged

Android Studio improvements #44310

merged 4 commits into from Aug 1, 2018

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 1, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@primeos primeos self-assigned this Aug 1, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: android-studio-preview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: android-studio-preview

Partial log (click to expand)

collision between `/nix/store/zr3n4vx9l22z5fp7b1zv1awp94v6z2lz-gcc-7.3.0-lib/lib/libgcc_s.so' and `/nix/store/jwshxi80myfvadl81kppm6a76q6r70ln-glibc-multi-2.27/lib/libgcc_s.so'
collision between `/nix/store/zr3n4vx9l22z5fp7b1zv1awp94v6z2lz-gcc-7.3.0-lib/lib/libgcc_s.so.1' and `/nix/store/jwshxi80myfvadl81kppm6a76q6r70ln-glibc-multi-2.27/lib/libgcc_s.so.1'
collision between `/nix/store/590id60kl4m0gkpnsbgias07c0zhndks-shadow-4.5/etc/login.defs' and `/nix/store/jirhpap3v67pjl826kz97rgpf8kya35n-android-studio-beta-3.2.0.22-fhs-env-chrootenv-etc/etc/login.defs'
collision between `/nix/store/590id60kl4m0gkpnsbgias07c0zhndks-shadow-4.5/etc/pam.d' and `/nix/store/jirhpap3v67pjl826kz97rgpf8kya35n-android-studio-beta-3.2.0.22-fhs-env-chrootenv-etc/etc/pam.d'
created 1088 symlinks in user environment
building '/nix/store/iwywyy98gy4r3y3i494mzw8xgckx7ina-android-studio-beta-3.2.0.22-fhs-env-fhs.drv'...
building '/nix/store/0pi2ys8inif03563ikfjcjcyqj6r1nla-android-studio-beta-3.2.0.22-fhs-env-init.drv'...
building '/nix/store/2m5shb12m5m3yvx6h0hqwdhy45zmrpif-android-studio-beta-3.2.0.22-fhs-env.drv'...
building '/nix/store/59jigjblci4v6cncrrvhn44vpi76wly3-android-studio-beta-3.2.0.22-wrapper.drv'...
/nix/store/cp4j0wiy7fzran9fai2kd3b8qm4b69w5-android-studio-beta-3.2.0.22-wrapper

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: android-studio-preview

Partial log (click to expand)

cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
wrong ELF type
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
building '/nix/store/ng5hp71f2v3jmcr6sszw9wn3r8xw3cj0-android-studio-beta-3.2.0.22-wrapper.drv'...
/nix/store/h2qrirh4gbf40m5b1107jqs12jd3dgab-android-studio-beta-3.2.0.22-wrapper

@primeos primeos changed the title Android studio improvements Android Studio improvements Aug 1, 2018
@primeos primeos merged commit 8aa04df into NixOS:master Aug 1, 2018
@LnL7
Copy link
Member

LnL7 commented Aug 1, 2018

I think this broke evaluation https://gist.github.com/GrahamcOfBorg/6b399b49b5528b9befa525051bd2c2f9

@primeos
Copy link
Member Author

primeos commented Aug 1, 2018

@LnL7 Looking at the last line:

attribute 'gconf' missing, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/pkgs/applications/networking/instant-messengers/gitter/default.nix:16:6

I think this was actually due to e090fb2, but thank you very much for the notification anyway 😄.

From the fist lines it definitely looks like this PR is responsible:

trace: android-studio-preview and androidStudioPackages.preview are old aliases
and will be dropped at some point, please use androidStudioPackages.beta
instead (corresponds to the correct channel name).

But that's actually supposed to be there (when building android-studio-preview or androidStudioPackages.preview), I'm not sure if that was a good idea though, let's hope this doesn't cause any problems with Hydra... (if it does or if we don't want this, we can revert 88bfbf6)

@vcunat
Copy link
Member

vcunat commented Aug 2, 2018 •
edited

There were apparently two problems at that point. ATM reverting your commit fixed the tarball job for me, so I pushed that. Maybe this is doable by fixing the tarball job instead, but at least for now...

EDIT: log, as Hydra's are badly shown now:

running tests
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
warning: you did not specify '--add-root'; the result might be removed by the garbage collector
checking Nixpkgs on i686-linux
trace: android-studio-preview and androidStudioPackages.preview are old aliases
and will be dropped at some point, please use androidStudioPackages.beta
instead (corresponds to the correct channel name).
Nixpkgs on i686-linux evaluated with warnings, aborting
build time elapsed:  0m0.087s 0m0.097s 0m32.663s 0m1.847s
builder for '/nix/store/bq6mlis3yqda1i4i98palhiml5zi6rzk-nixpkgs-tarball-18.09pre1234.abcdef.drv' failed with exit code 1

vcunat added a commit that referenced this pull request Aug 2, 2018
@vcunat
Revert "android-studio-preview: Print a deprecation warning"
86b5b1e 
This reverts commit 88bfbf6.
It broke the tarball job.  Discussion:
#44310 (comment)
@vcunat
Copy link
Member

vcunat commented Aug 2, 2018 •
edited

AFAIK we don't yet have a good way of deprecating attribute paths in nixpkgs. (We do for NixOS options.) I've tried to fight this at some point, but I haven't managed a way (yet). It usually boils down to the inability to differentiate between explicit usage of an attribute and listing via nix-env -qa.

@primeos
Copy link
Member Author

primeos commented Aug 3, 2018

@vcunat Thank you very much for reverting it and sorry for any inconvenience caused (was hoping it would be fine...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
0.kind: enhancement 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @GrahamcOfBorg @LnL7 @vcunat