Support specifying custom S3 endpoints for non-Amazon S3-Compatible APIs #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlevy
approved these changes
Aug 1, 2018
Works for uploading and not downloading.
graham-at-target
force-pushed
the
s3-endpoint
branch
from
2951cef
to
49a53c1
Compare
|
Ok, this is rebased after the merge of the docs section and now only contains the endpoint code. |
|
The thing that makes this cool is we could now do some automated testing here with minio or other light-weight S3-like APIs. On top of private cloud people being able to use private clouds :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon #2319 for the docs fix. See just
2951cef for the meat of this PR.
cc @shlevy