Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supercollider: fix MIDI support on Linux #44306

Closed
wants to merge 1 commit into from
Closed

Supercollider: fix MIDI support on Linux #44306

wants to merge 1 commit into from

Conversation

sleexyz
Copy link
Contributor

@sleexyz sleexyz commented Aug 1, 2018

This PR fixes broken MIDI functionality in the Supercollider IDE.

Motivation for this change

Supercollider's IDE's MIDI support only works on Linux if compiled with ALSA.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@sleexyz
Supercollider: add alsaLib as a dependency
23d2944 
This PR fixes broken MIDI functionality in the Supercollider IDE.

Supercollider's IDE's MIDI support only works if compiled with ALSA as it uses ALSA for MIDI on Linux.
@sleexyz
Copy link
Contributor Author

sleexyz commented Aug 1, 2018

Closing until it works locally...

@sleexyz sleexyz closed this Aug 1, 2018
@yurkobb
Copy link
Contributor

yurkobb commented Oct 26, 2018

My attempt on this branch, working on a PR. Seems to work fine locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sleexyz @yurkobb @GrahamcOfBorg