Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 402ee4e9eaf0
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: c27f686a4b4f
Choose a head ref
  • 2 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 19, 2018

  1. bazel: make more tools available in customBash.

    @mboes @Profpatsch
    mboes authored and Profpatsch committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    5ab07a8 View commit details
    Browse the repository at this point in the history

  2. bazel: Set a sensible strict action environment. 

    Bazel either reuses the `PATH` from the client, or sets a hardcoded
one. The former mode in problematic for build hermeticity. But the
latter is crippled on NixOS, because the hardcoded value is
`/bin:/usr/bin`. So we set the hardcoded value to match what
`customBash` provides. This has the effect of aligning the
environments for `ctx.actions.run` and `ctx.actions.run_shell`, which
were previously distinct (bug).
    @mboes @Profpatsch
    mboes authored and Profpatsch committed Jul 19, 2018
    Configuration menu
    Copy the full SHA
    c27f686 View commit details
    Browse the repository at this point in the history