Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urbit: 0.4.5 -> 0.6.0 #43799

Merged
merged 3 commits into from Aug 5, 2018
Merged

urbit: 0.4.5 -> 0.6.0 #43799

merged 3 commits into from Aug 5, 2018

Conversation

jglukasik
Copy link
Contributor

Motivation for this change

Version was out of date, and install procedure has changed (following https://urbit.org/docs/using/install/ )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build urbit

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: urbit

Partial log (click to expand)

Installing softfloat_types.h to /nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0/include/softfloat3
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0
shrinking /nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0/bin/urbit
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0/lib  /nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0/bin
patching script interpreter paths in /nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0
checking for references to /build in /nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0...
/nix/store/8x8sh2xs9jzwwgjf2vqmdijricry18if-urbit-0.6.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: urbit

Partial log (click to expand)

Installing softfloat_types.h to /nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0/include/softfloat3
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0
shrinking /nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0/bin/urbit
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0/lib  /nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0/bin
patching script interpreter paths in /nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0
checking for references to /build in /nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0...
/nix/store/qk7pv1by8x2804zixa05xi9nzqd6ckag-urbit-0.6.0

matthewbauer
matthewbauer previously requested changes Jul 25, 2018
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it’s best to avoid bootstrap scripts. Nix should already bootstrap everything for you. We have meson and ninja built so that you shouldn’t have to specify a buildPhase at all.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: urbit

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@jglukasik
urbit: Don't use bootstrap scripts, no buildPhase
8c673da 
Incorporating feedback from NixOS#43799

Also cleaned up some cruft from previous versions that didn't build with Meson/Ninja.
@jglukasik
Copy link
Contributor Author

Thank you for your feedback @matthewbauer . This is my first nixpkgs contribution, I admit to some cargo-culting 🙂

I was able to clean this up a bit and avoid using the bootstrap scripts and buildPhase.

@globin globin merged commit 93a0569 into NixOS:master Aug 5, 2018
globin pushed a commit that referenced this pull request Aug 5, 2018
@jglukasik @globin
urbit: Don't use bootstrap scripts, no buildPhase
2687591 
Incorporating feedback from #43799

Also cleaned up some cruft from previous versions that didn't build with Meson/Ninja.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jglukasik @matthewbauer @GrahamcOfBorg @globin @Janik-Haag