[WIP] find Haskell dependencies during evaluation rather than at run-time #43804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this affect Nixpkgs evaluation performance? |
nh2
reviewed
Jul 19, 2018
|
|
|
I realize that I don't have the time & energy to push this through all by myself at the moment. The code lives in https://github.com/peti/nixpkgs/tree/haskell-update-generic-builder. I may revisit this topic in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that Haskell packages no longer need to be visible to the generic Nix builder, i.e. we no longer list them in
buildInputs.To see what has changes, run
diff -ub generic-builder.nix generic-builder-static.nix. I kept the old builder in place for all non-ghc-8.4.x package sets so that I don't have to re-build the compiler every time I change the code.Things left to do:
--disable-optimizationflag.$PATH(unless they are listed as a build tool).setupHaskellDependset al.generic-builder-static.nixthe default builder for all package sets.lib?dev?haskellPackages.libX11runs a configure script that is blissfully unaware of the configured--extra-include-dirsand therefore can't find the necessary libraries. Is there a way to pass those flags on from Cabal to the configure script?Ping @Ericson2314, @angerman, @domenkozar, @nh2.