Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fluentd: 0.14.11 -> 1.2.3 #43791

Merged
merged 1 commit into from Feb 24, 2019
Merged

fluentd: 0.14.11 -> 1.2.3 #43791

merged 1 commit into from Feb 24, 2019

Conversation

kiloreux
Copy link
Member

@kiloreux kiloreux commented Jul 19, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

@GrahamcOfBorg build fluentd

Can you check that the nixos module still works?

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fluentd

Partial log (click to expand)

  Gem home: /nix/store/1bal8j53yd10kpnicj9idyzq5g2xqik7-ruby2.4.4-fluent-plugin-kinesis-2.1.1/lib/ruby/gems/2.4.0
Successfully installed fluent-plugin-kinesis-2.1.1
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1bal8j53yd10kpnicj9idyzq5g2xqik7-ruby2.4.4-fluent-plugin-kinesis-2.1.1
patching script interpreter paths in /nix/store/1bal8j53yd10kpnicj9idyzq5g2xqik7-ruby2.4.4-fluent-plugin-kinesis-2.1.1
checking for references to /build in /nix/store/1bal8j53yd10kpnicj9idyzq5g2xqik7-ruby2.4.4-fluent-plugin-kinesis-2.1.1...
building '/nix/store/838r3vvasz5klmz40cbn8dx8sh7xgxdg-fluentd-1.2.3.drv'...
created 595 symlinks in user environment
/nix/store/vrxmnmgzmsn3gm6fiq43mwlryvrbqjad-fluentd-1.2.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fluentd

Partial log (click to expand)

  Gem home: /nix/store/zlwxli580jnk949ikp6ibnx87aiya3xb-ruby2.4.4-fluent-plugin-kinesis-2.1.1/lib/ruby/gems/2.4.0
Successfully installed fluent-plugin-kinesis-2.1.1
1 gem installed
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zlwxli580jnk949ikp6ibnx87aiya3xb-ruby2.4.4-fluent-plugin-kinesis-2.1.1
patching script interpreter paths in /nix/store/zlwxli580jnk949ikp6ibnx87aiya3xb-ruby2.4.4-fluent-plugin-kinesis-2.1.1
checking for references to /build in /nix/store/zlwxli580jnk949ikp6ibnx87aiya3xb-ruby2.4.4-fluent-plugin-kinesis-2.1.1...
building '/nix/store/ap1p40i47n3pm9bx55ip0iag2xi2y5f7-fluentd-1.2.3.drv'...
created 595 symlinks in user environment
/nix/store/37b8rn2k7i6ajklrqic3qkc1pgi3jmmn-fluentd-1.2.3

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@GrahamcOfBorg build fluentd

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

I used mic92's nixos-shell to test that systemd starts fluentd without error with this PR applied onto master.

@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

fluentd was already failing on darwin

@ryantm ryantm merged commit f6fc56b into NixOS:master Feb 24, 2019
@ryantm
Copy link
Member

ryantm commented Feb 24, 2019

@kiloreux thanks; please consider adding yourself as a maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kiloreux @infinisil @GrahamcOfBorg @ryantm