Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bfs: enable the test_fstype test #43810

Merged
merged 1 commit into from Jul 25, 2018
Merged

bfs: enable the test_fstype test #43810

merged 1 commit into from Jul 25, 2018

Conversation

yesbox
Copy link
Contributor

@yesbox yesbox commented Jul 19, 2018

This test would previously fail in the nix build sandbox.
It was fixed in version 1.2.2.

Tested with both 1.2.2 and 1.2.3. Please merge together with #43793.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@yesbox
bfs: enable the test_fstype test
9877ba5 
This test would previously fail in the nix build sandbox.
It was fixed in version 1.2.2.
@yesbox yesbox mentioned this pull request Jul 22, 2018
Merged
9 tasks
@matthewbauer matthewbauer merged commit 0aa2a93 into NixOS:master Jul 25, 2018
@yesbox yesbox deleted the bfs branch September 22, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yesbox @matthewbauer @GrahamcOfBorg