kube-shell: init at 0.0.21 #43802

carlosdagos · 2018-07-19T08:11:19Z

Motivation for this change

Nice shell for kubectl 😄

I don't know if development/tools is the most appropriate place for this though. I'll happy to change it otherwise.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

matthewbauer · 2018-07-25T17:24:01Z

@GrahamcOfBorg build kube-shell

GrahamcOfBorg · 2018-07-25T17:24:38Z

Failure on x86_64-linux (full log)

Attempted: kube-shell

Partial log (click to expand)

Reading https://pypi.org/simple/kubernetes/
Download error on https://pypi.org/simple/kubernetes/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'kubernetes' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for kubernetes<3.0.0,>=0.10.0
error: Could not find suitable distribution for Requirement.parse('kubernetes<3.0.0,>=0.10.0')
builder for '/nix/store/d2lby71mdysch4frj7kpb93n94rs0012-kube-shell-0.0.21.drv' failed with exit code 1
error: build of '/nix/store/d2lby71mdysch4frj7kpb93n94rs0012-kube-shell-0.0.21.drv' failed

GrahamcOfBorg · 2018-07-25T17:24:44Z

Failure on aarch64-linux (full log)

Attempted: kube-shell

Partial log (click to expand)

Reading https://pypi.org/simple/kubernetes/
Download error on https://pypi.org/simple/kubernetes/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'kubernetes' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for kubernetes<3.0.0,>=0.10.0
error: Could not find suitable distribution for Requirement.parse('kubernetes<3.0.0,>=0.10.0')
builder for '/nix/store/mazws7dhrzljh7r50zw72rk2ra977dz0-kube-shell-0.0.21.drv' failed with exit code 1
error: build of '/nix/store/mazws7dhrzljh7r50zw72rk2ra977dz0-kube-shell-0.0.21.drv' failed

GrahamcOfBorg · 2018-07-25T17:28:15Z

Failure on x86_64-linux (full log)

Attempted: kube-shell

Partial log (click to expand)

Reading https://pypi.org/simple/kubernetes/
Download error on https://pypi.org/simple/kubernetes/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'kubernetes' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for kubernetes<3.0.0,>=0.10.0
error: Could not find suitable distribution for Requirement.parse('kubernetes<3.0.0,>=0.10.0')
builder for '/nix/store/d2lby71mdysch4frj7kpb93n94rs0012-kube-shell-0.0.21.drv' failed with exit code 1
error: build of '/nix/store/d2lby71mdysch4frj7kpb93n94rs0012-kube-shell-0.0.21.drv' failed

GrahamcOfBorg · 2018-07-25T17:28:18Z

Failure on aarch64-linux (full log)

Attempted: kube-shell

Partial log (click to expand)

Reading https://pypi.org/simple/kubernetes/
Download error on https://pypi.org/simple/kubernetes/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'kubernetes' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for kubernetes<3.0.0,>=0.10.0
error: Could not find suitable distribution for Requirement.parse('kubernetes<3.0.0,>=0.10.0')
builder for '/nix/store/mazws7dhrzljh7r50zw72rk2ra977dz0-kube-shell-0.0.21.drv' failed with exit code 1
error: build of '/nix/store/mazws7dhrzljh7r50zw72rk2ra977dz0-kube-shell-0.0.21.drv' failed

GrahamcOfBorg · 2018-07-25T17:28:36Z

Failure on aarch64-linux (full log)

Attempted: kube-shell

Partial log (click to expand)

Reading https://pypi.org/simple/kubernetes/
Download error on https://pypi.org/simple/kubernetes/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'kubernetes' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for kubernetes<3.0.0,>=0.10.0
error: Could not find suitable distribution for Requirement.parse('kubernetes<3.0.0,>=0.10.0')
builder for '/nix/store/mazws7dhrzljh7r50zw72rk2ra977dz0-kube-shell-0.0.21.drv' failed with exit code 1
error: build of '/nix/store/mazws7dhrzljh7r50zw72rk2ra977dz0-kube-shell-0.0.21.drv' failed

GrahamcOfBorg · 2018-07-25T17:28:56Z

Failure on x86_64-linux (full log)

Attempted: kube-shell

Partial log (click to expand)

Reading https://pypi.org/simple/kubernetes/
Download error on https://pypi.org/simple/kubernetes/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'kubernetes' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for kubernetes<3.0.0,>=0.10.0
error: Could not find suitable distribution for Requirement.parse('kubernetes<3.0.0,>=0.10.0')
builder for '/nix/store/d2lby71mdysch4frj7kpb93n94rs0012-kube-shell-0.0.21.drv' failed with exit code 1
error: build of '/nix/store/d2lby71mdysch4frj7kpb93n94rs0012-kube-shell-0.0.21.drv' failed

GrahamcOfBorg · 2018-07-25T19:21:27Z

Success on x86_64-darwin (full log)

Attempted: kube-shell

Partial log (click to expand)

wrapping `/nix/store/mrj8972g4hpy1anhsclvh6apy7hwhx3d-kube-shell-0.0.21/bin/pyrsa-sign'...
wrapping `/nix/store/mrj8972g4hpy1anhsclvh6apy7hwhx3d-kube-shell-0.0.21/bin/pyrsa-verify'...
wrapping `/nix/store/mrj8972g4hpy1anhsclvh6apy7hwhx3d-kube-shell-0.0.21/bin/wsdump.py'...
running install tests
.
----------------------------------------------------------------------
Ran 1 test in 3.611s

OK
/nix/store/mrj8972g4hpy1anhsclvh6apy7hwhx3d-kube-shell-0.0.21

GrahamcOfBorg · 2018-07-25T19:21:50Z

Success on x86_64-darwin (full log)

Attempted: kube-shell

Partial log (click to expand)

/nix/store/mrj8972g4hpy1anhsclvh6apy7hwhx3d-kube-shell-0.0.21

GrahamcOfBorg · 2018-07-25T19:21:58Z

Success on x86_64-darwin (full log)

Attempted: kube-shell

Partial log (click to expand)

/nix/store/mrj8972g4hpy1anhsclvh6apy7hwhx3d-kube-shell-0.0.21

carlosdagos · 2018-07-25T22:14:11Z

Seems like the build failures were due to some network error?

Download error on https://pypi.org/simple/kubernetes/: [Errno -2] Name or service not known -- Some packages may not be found!

Still kind of weird that it only succeeded in Darwin 😕

matthewbauer · 2018-07-25T22:45:18Z

It is probably a sandbox issue. Darwin should fail but the sandbox is broken.

carlosdagos · 2018-07-27T03:53:55Z

Do you think it's a matter of retrying @matthewbauer? I tried to build using Ubuntu and also worked. I can try NixOS too if that helps.

matthewbauer · 2018-07-27T17:02:23Z

pkgs/development/tools/kube-shell/default.nix

+
+  buildInputs = with pythonPackages; [ pexpect ];
+
+  buildPhase = ''


You should be able to use the builtin buildPhase provided by buildPythonApplication

matthewbauer · 2018-07-27T17:02:44Z

pkgs/development/tools/kube-shell/default.nix

+    owner = "cloudnativelabs";
+  };
+
+  buildInputs = with pythonPackages; [ pexpect ];


You will need to add to build inputs all of these:

'prompt-toolkit>=1.0.10,<1.1.0', 'Pygments>=2.1.3,<3.0.0', 'fuzzyfinder>=1.0.0', 'click>=4.0,<7.0', 'kubernetes>=0.10.0,<3.0.0',

matthewbauer · 2018-07-27T17:02:59Z

pkgs/development/tools/kube-shell/default.nix

+    ${python.interpreter} setup.py build
+  '';
+
+  installPhase = ''


Install phase should also be handled by buildPythonApplication.

carlosdagos · 2019-04-02T00:23:33Z

This one is pretty stale by now. Will look at it again and open another PR if necessary 👍 Thanks!

kube-shell: init at 0.0.21

423972a

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 19, 2018

matthewbauer reviewed Jul 27, 2018

View reviewed changes

matthewbauer requested changes Jul 27, 2018

View reviewed changes

xeji added the 2.status: merge conflict label Aug 1, 2018

carlosdagos closed this Apr 2, 2019

carlosdagos deleted the kube-shell branch April 2, 2019 00:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kube-shell: init at 0.0.21 #43802

kube-shell: init at 0.0.21 #43802

carlosdagos commented Jul 19, 2018 •

edited

matthewbauer commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

carlosdagos commented Jul 25, 2018

matthewbauer commented Jul 25, 2018

carlosdagos commented Jul 27, 2018

matthewbauer Jul 27, 2018

matthewbauer Jul 27, 2018

matthewbauer Jul 27, 2018

carlosdagos commented Apr 2, 2019


		buildInputs = with pythonPackages; [ pexpect ];

		buildPhase = ''

kube-shell: init at 0.0.21 #43802

kube-shell: init at 0.0.21 #43802

Conversation

carlosdagos commented Jul 19, 2018 • edited

Motivation for this change

Things done

matthewbauer commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

GrahamcOfBorg commented Jul 25, 2018

carlosdagos commented Jul 25, 2018

matthewbauer commented Jul 25, 2018

carlosdagos commented Jul 27, 2018

matthewbauer Jul 27, 2018

Choose a reason for hiding this comment

matthewbauer Jul 27, 2018

Choose a reason for hiding this comment

matthewbauer Jul 27, 2018

Choose a reason for hiding this comment

carlosdagos commented Apr 2, 2019

carlosdagos commented Jul 19, 2018 •

edited