Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/release: pass individual netboot files through #43805

Closed
wants to merge 1 commit into from
Closed

nixos/release: pass individual netboot files through #43805

wants to merge 1 commit into from

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Jul 19, 2018 •
edited

Motivation for this change

Enabling placing netboot files in channels so we can add https://netboot.xyz support. See also netbootxyz/netboot.xyz#37

Would be nice to backport to 18.03, not sure if that's ok?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@lheckemann lheckemann mentioned this pull request Jul 19, 2018
Closed
@lheckemann
Copy link
Member Author

This is the wrong approach, since the files are exposed via hydra using the derivation's metadata and can thus be downloaded separately already.

@lheckemann lheckemann closed this Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lheckemann @GrahamcOfBorg