Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postman: fix icon not found #43807

Merged
merged 1 commit into from Jul 21, 2018
Merged

postman: fix icon not found #43807

merged 1 commit into from Jul 21, 2018

Conversation

borisbabic
Copy link
Contributor

@borisbabic borisbabic commented Jul 19, 2018 •
edited

Motivation for this change

Postman doesn't build because the icon is no longer present at the old url

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 03b18cc into NixOS:master Jul 21, 2018
@Mic92
Copy link
Member

Mic92 commented Jul 21, 2018

Does this need a backport?

@borisbabic
Copy link
Contributor Author

I just checked the 18.03 branch and it has an older version of postman (5.5.2 vs 5.5.3) that doesn't have this issue. It actually handles the icon better than the current version (extracts it from the package instead of downloading it).

@borisbabic
Copy link
Contributor Author

Now I dislike this fix :D

I was planning on sending a pull request to update postman to 6.1.4 sometime soon so when I do I'll use the icon from the package instead of downloading it separately and then the version in master will be less fragile.

@borisbabic borisbabic deleted the bugs/postman_icon branch July 21, 2018 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@borisbabic @Mic92 @GrahamcOfBorg @Janik-Haag