Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libebml: 1.3.5 -> 1.3.6 and libmatroska: 1.4.8 -> 1.4.9 #43519

Merged
merged 2 commits into from Jul 14, 2018
Merged

libebml: 1.3.5 -> 1.3.6 and libmatroska: 1.4.8 -> 1.4.9 #43519

merged 2 commits into from Jul 14, 2018

Conversation

peterhoeg
Copy link
Member

@peterhoeg peterhoeg commented Jul 14, 2018 •
edited

Motivation for this change

Upstream update. Both projects have been converted to use cmake so they need to be updated at the same time.


###### Things done

<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->

- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)
- Built on platform(s)
   - [x] NixOS
   - [ ] macOS
   - [ ] other Linux distributions
- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))
- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"`
- [ ] Tested execution of all binary files (usually in `./result/bin/`)
- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)
- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).

---

@peterhoeg peterhoeg changed the title libebml: 1.3.5 -> 1.3.6 and libmatroska: 1.4.8 -> 1.4.9 [WIP] libebml: 1.3.5 -> 1.3.6 and libmatroska: 1.4.8 -> 1.4.9 Jul 14, 2018
@peterhoeg peterhoeg merged commit d4f6320 into NixOS:master Jul 14, 2018
@peterhoeg peterhoeg deleted the u/matroska branch July 14, 2018 14:26
@peterhoeg peterhoeg restored the u/matroska branch July 15, 2018 16:39
@peterhoeg peterhoeg deleted the u/matroska branch October 8, 2018 01:26
@peterhoeg peterhoeg restored the u/matroska branch October 8, 2018 11:44
@peterhoeg peterhoeg deleted the u/matroska branch March 18, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @GrahamcOfBorg