Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.backports_ssl_match_hostname_3_4_0_2: remove #43544

Merged
merged 2 commits into from Jul 15, 2018
Merged

python.pkgs.backports_ssl_match_hostname_3_4_0_2: remove #43544

merged 2 commits into from Jul 15, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

We don't want multiple versions of the same package in pythonPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner July 14, 2018 23:34
@dotlambda
Copy link
Member Author

dotlambda commented Jul 15, 2018 •
edited

The third commit is optional. Its intention is to reduce the number of rebuilds.

@dotlambda dotlambda force-pushed the drop-backports_ssl_match_hostname_3_4_0_2 branch from 298353e to ecd3287 Compare July 15, 2018 00:10
@FRidh
Copy link
Member

FRidh commented Jul 15, 2018

The last commit is optional. Its intention is to reduce the number of rebuilds.

Don't bother, it's fine when it goes to staging.

@dotlambda dotlambda force-pushed the drop-backports_ssl_match_hostname_3_4_0_2 branch from ecd3287 to 18ecdd1 Compare July 15, 2018 21:20
@dotlambda dotlambda merged commit eea1776 into NixOS:staging Jul 15, 2018
@dotlambda dotlambda deleted the drop-backports_ssl_match_hostname_3_4_0_2 branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @FRidh @GrahamcOfBorg