Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitter: init at 4.1.0 #43505

Merged
merged 1 commit into from Aug 1, 2018
Merged

gitter: init at 4.1.0 #43505

merged 1 commit into from Aug 1, 2018

Conversation

colonelpanic8
Copy link
Contributor

Motivation for this change

Add gitter client

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Jul 14, 2018

The commit message shouldn't have a "v" before the version number.

@GrahamcOfBorg build gitter

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: gitter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: gitter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitter

Partial log (click to expand)

checking for references to /build in /nix/store/cxm5cj1gpxprx5vpchi8nfc5vll5ms2i-gitter-4.1.0...
cannot find section .dynamic
wrong ELF type
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/cxm5cj1gpxprx5vpchi8nfc5vll5ms2i-gitter-4.1.0

@colonelpanic8 colonelpanic8 changed the title gitter: init at v4.1.0 gitter: init at 4.1.0 Jul 15, 2018
@colonelpanic8
Copy link
Contributor Author

@ryantm done

fpletz
fpletz reviewed Jul 15, 2018
View reviewed changes
pkgs/applications/networking/instant-messengers/gitter/default.nix
meta = with stdenv.lib; {
description = "Where developers come to talk";
downloadPage = "https://gitter.im/apps";
license = licenses.mit;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really MIT-licensed? I can't find the source anywhere. Or are the binaries MIT-licensed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe https://gitlab.com/gitlab-org/gitter/webapp/blob/develop/LICENSE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryantm yeah, pretty close, although that is for the web app. This is the desktop app license: https://gitlab.com/gitlab-org/gitter/desktop/blob/master/LICENSE.md

@xeji xeji merged commit e090fb2 into NixOS:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

@fpletz fpletz fpletz left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colonelpanic8 @ryantm @GrahamcOfBorg @fpletz @xeji