Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reference links to .from_io methods #6384

Closed
wants to merge 1 commit into from
Closed

Fix reference links to .from_io methods #6384

wants to merge 1 commit into from

Conversation

faustinoaq
Copy link
Contributor

Ref: read_bytes

Notice the "See ..." section

image

Comparison to write_bytes

image

Sija
Sija reviewed Jul 14, 2018
View reviewed changes
Copy link
Contributor

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's incorrect, since they're class methods.

@faustinoaq
Copy link
Contributor Author

That's incorrect, since they're class methods.

@Sija Oh, you're right, #to_io is different to .from_io 😅 , Any idea why this link wasn't generated here?

@faustinoaq faustinoaq closed this Jul 14, 2018
@faustinoaq faustinoaq deleted the patch-1 branch July 14, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faustinoaq @Sija