Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: Pass dontStrip to cabal. Fixes #43506 #43508

Merged
merged 1 commit into from Jul 17, 2018
Merged

haskell: Pass dontStrip to cabal. Fixes #43506 #43508

merged 1 commit into from Jul 17, 2018

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Jul 14, 2018

Motivation for this change

See #43506

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

CC @peti

@nh2 nh2 requested a review from peti as a code owner July 14, 2018 01:43
@nh2 nh2 mentioned this pull request Jul 14, 2018
Closed
@nh2
Copy link
Contributor Author

nh2 commented Jul 14, 2018

I've tested this using

NIX_PATH=nixpkgs=. nix-build --expr 'with import <nixpkgs> {}; haskell.lib.overrideCabal haskellPackages.hello (old: { dontStrip = true; postInstall = "${pkgs.file}/bin/file dist/build/hello/hello $out/bin/hello"; })'

@peti peti merged commit b412cac into NixOS:master Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nh2 @matthewbauer @peti @GrahamcOfBorg