Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2018.05.18 -> 2018.07.10 #43548

Merged
merged 1 commit into from Jul 15, 2018
Merged

youtube-dl: 2018.05.18 -> 2018.07.10 #43548

merged 1 commit into from Jul 15, 2018

Conversation

Enzime
Copy link
Member

@Enzime Enzime commented Jul 15, 2018

Also remove with stdenv.lib from Nix derivation to make it clearer
where variables are coming from.

Things done
  • Tested without sandboxing on macOS
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Enzime
youtube-dl: 2018.05.18 -> 2018.07.10
6308fa8 
Also remove `with stdenv.lib` from Nix derivation to make it clearer
where variables are coming from.
@adisbladis
Copy link
Member

@GrahamcOfBorg build youtube-dl

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.7.10
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2is783ra9vfh60y3b2h87hfs6rmpbw39-python2.7-youtube-dl-2018.07.10
gzipping man pages under /nix/store/2is783ra9vfh60y3b2h87hfs6rmpbw39-python2.7-youtube-dl-2018.07.10/share/man/
strip is /nix/store/0pjsgkxz0rp5baycq5sp2s72lrr5q9sg-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2is783ra9vfh60y3b2h87hfs6rmpbw39-python2.7-youtube-dl-2018.07.10/lib  /nix/store/2is783ra9vfh60y3b2h87hfs6rmpbw39-python2.7-youtube-dl-2018.07.10/bin
patching script interpreter paths in /nix/store/2is783ra9vfh60y3b2h87hfs6rmpbw39-python2.7-youtube-dl-2018.07.10
checking for references to /build in /nix/store/2is783ra9vfh60y3b2h87hfs6rmpbw39-python2.7-youtube-dl-2018.07.10...
wrapping `/nix/store/2is783ra9vfh60y3b2h87hfs6rmpbw39-python2.7-youtube-dl-2018.07.10/bin/youtube-dl'...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.7.10
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xpn6xygjfp045mcfcg8dc7s3bjxcza8g-python2.7-youtube-dl-2018.07.10
gzipping man pages under /nix/store/xpn6xygjfp045mcfcg8dc7s3bjxcza8g-python2.7-youtube-dl-2018.07.10/share/man/
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xpn6xygjfp045mcfcg8dc7s3bjxcza8g-python2.7-youtube-dl-2018.07.10/lib  /nix/store/xpn6xygjfp045mcfcg8dc7s3bjxcza8g-python2.7-youtube-dl-2018.07.10/bin
patching script interpreter paths in /nix/store/xpn6xygjfp045mcfcg8dc7s3bjxcza8g-python2.7-youtube-dl-2018.07.10
checking for references to /build in /nix/store/xpn6xygjfp045mcfcg8dc7s3bjxcza8g-python2.7-youtube-dl-2018.07.10...
wrapping `/nix/store/xpn6xygjfp045mcfcg8dc7s3bjxcza8g-python2.7-youtube-dl-2018.07.10/bin/youtube-dl'...

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: youtube-dl

Partial log (click to expand)

  The script youtube-dl is installed in '/nix/store/227k0zrk5x09csym63l4xk7lfrpwvwbc-python2.7-youtube-dl-2018.07.10/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed youtube-dl-2018.7.10
/private/tmp/nix-build-python2.7-youtube-dl-2018.07.10.drv-0/youtube-dl
post-installation fixup
gzipping man pages under /nix/store/227k0zrk5x09csym63l4xk7lfrpwvwbc-python2.7-youtube-dl-2018.07.10/share/man/
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/227k0zrk5x09csym63l4xk7lfrpwvwbc-python2.7-youtube-dl-2018.07.10/lib  /nix/store/227k0zrk5x09csym63l4xk7lfrpwvwbc-python2.7-youtube-dl-2018.07.10/bin
patching script interpreter paths in /nix/store/227k0zrk5x09csym63l4xk7lfrpwvwbc-python2.7-youtube-dl-2018.07.10
wrapping `/nix/store/227k0zrk5x09csym63l4xk7lfrpwvwbc-python2.7-youtube-dl-2018.07.10/bin/youtube-dl'...

@adisbladis adisbladis merged commit d3ed77f into NixOS:master Jul 15, 2018
@Enzime Enzime deleted the update/youtube-dl branch August 4, 2018 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Enzime @adisbladis @GrahamcOfBorg