Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell/network: 2.6.3.4 -> 2.6.3.6 (release-18.03) #43549

Merged
merged 1 commit into from Jul 16, 2018
Merged

haskell/network: 2.6.3.4 -> 2.6.3.6 (release-18.03) #43549

merged 1 commit into from Jul 16, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

@peti network-2.6.3.6 fixes some bugs that I'm currently suffering from in our 18.03 production systems.

http://hackage.haskell.org/package/network-2.6.3.6/changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk basvandijk requested a review from peti as a code owner July 15, 2018 01:45
@basvandijk basvandijk changed the title haskell/network: 2.6.3.4 -> 2.6.3.6 haskell/network: 2.6.3.4 -> 2.6.3.6 (release-18.03) Jul 15, 2018
infinisil
infinisil requested changes Jul 15, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated, you should put modifications to it into pkgs/development/haskell-modules/configuration-*.nix

@basvandijk
Copy link
Member Author

Since hackage-packages.nix in master already has network-2.6.3.6 the next time this file gets regenerated in release-18.03 it will also get network-2.6.3.6. So I think making the change in that file is less of a maintenance burden than making an override in configuration-common.nix because that has to be removed later. Let me know if my reasoning is flawed then I'll make an override.

peti
peti approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe in this particular case it's fine (and actually preferable) to edit the hackage-packages.nix file directly. If we ever update the package set in the release branch, then we'll end up with that version anyway and an override does need to be removed in such a case.

@peti peti merged commit a4110f3 into NixOS:release-18.03 Jul 16, 2018
@infinisil
Copy link
Member

I see, I didn't think of that, neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil requested changes

@peti peti peti approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basvandijk @infinisil @peti @GrahamcOfBorg