Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gurobi: init at 8.0.1 #43543

Merged
merged 1 commit into from Jul 15, 2018
Merged

gurobi: init at 8.0.1 #43543

merged 1 commit into from Jul 15, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

See #32513

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @bbarker @shlevy

shlevy
shlevy reviewed Jul 14, 2018
View reviewed changes
pkgs/applications/science/math/gurobi/default.nix
sourceRoot = "gurobi${builtins.replaceStrings ["."] [""] version}/linux64";

nativeBuildInputs = [ autoPatchelfHook ];
buildInputs = [ (python.withPackages (ps: [ ps.gurobipy ])) ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work by just having python and pythonPackages.gurobipy here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without python.withPackages the Gurobi interactive shell (which is a python script) is not able to find the gurobipy module.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfrankenau Even when python itself is in the buildInputs? Interesting, OK.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, even then. Is there any disadvantage of using python.withPackages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that I know of, no.

@shlevy shlevy merged commit d6874a7 into NixOS:master Jul 15, 2018
@jfrankenau jfrankenau deleted the init-gurobi branch July 16, 2018 06:24
@veprbl veprbl mentioned this pull request Nov 28, 2018
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlevy shlevy shlevy left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @shlevy @GrahamcOfBorg