charles: init at 4.2.6 #43502
charles: init at 4.2.6 #43502
Conversation
pkgs/top-level/all-packages.nix
Outdated
| @@ -3718,7 +3720,7 @@ with pkgs; | |||
| lzip = callPackage ../tools/compression/lzip { }; | |||
|
|
|||
| luxcorerender = callPackage ../tools/graphics/luxcorerender { }; | |||
|
|
|||
There was a problem hiding this comment.
While I hate trailing whitespace could you remove these changes from this PR?
There was a problem hiding this comment.
@adisbladis done, PTAL.
| done | ||
| done | ||
|
|
||
| install -D -m644 doc/licenses/bounce-license.txt \ |
There was a problem hiding this comment.
Are licenses really required in the output?
There was a problem hiding this comment.
I was not sure how NixOS deals with licenses, so I removed it.
| mkdir -p $out/share/applications | ||
| ln -s ${desktopItem}/share/applications/* $out/share/applications/ | ||
|
|
||
| for dim in 16x16 32x32 64x64 128x128 256x256 512x512; do |
There was a problem hiding this comment.
Why not something like:
for dim in icon/*; do
dim=$(basename $dim)
doneThen we don't have to track resolutions in the nix expression.
There was a problem hiding this comment.
My bad, I did not go through the details much, copied this from AUR. I'll clean it up right away.
| }; | ||
|
|
||
| installPhase = '' | ||
| set -e |
There was a problem hiding this comment.
-e is already implicit in nix builds
| for dim in 16x16 32x32 64x64 128x128 256x256 512x512; do | ||
| install -D -m644 icon/$dim/apps/charles-proxy.png \ | ||
| $out/share/icons/hicolor/$dim/apps/charles.png | ||
| for mimetype in application-har+json.png application-vnd.tcpdump.pcap.png application-x-charles-savedsession.png application-x-charles-trace.png; do |
There was a problem hiding this comment.
Can we do something similar here? It seems brittle to manually track these files.
|
@adisbladis PTAL. Also, the icons are named |
|
@volth PTAL |
|
Hmm.. I just noticed that this is trialware. I don't know what the stance on such packages is within nixpkgs? |
|
Ok then I guess it's fine. |
Motivation for this change
Charles is an HTTP proxy / HTTP monitor / Reverse Proxy that enables a developer to view all of the HTTP and SSL / HTTPS traffic between their machine and the Internet. This includes requests, responses and the HTTP headers (which contain the cookies and caching information).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)