Fix version check for LLVM < 6.0 #6383
Conversation
This is a minor fixup for the LLVM 6.0 support quick fix that changes the versions check for "below 6.0" (<= 5.9) to <= 5.0 since there wont be any new 5.x versions after 5.0.
|
Not sure this is worth merging, it works fine as-is. |
|
http://blog.llvm.org/2016/12/llvms-new-versioning-scheme.html
|
|
This is either an incorrect PR or a purely-aesthetic change, depending on the implementation of |
|
Why not change the 9 to a prettier number like 42? |
I can assure you it is not incorrect, the previous code was. The The only reason I initially used 5.9 as a check, is because I wanted to write "lower than 6.0" and then noticed the macro was lower-than-or-equal so I change it from 6.0 to 5.9, which technically works, but is confusing to the reader of the code. |
This is a minor fixup for the LLVM 6.0 support quick fix (#6380) that changes the versions check for "below 6.0" (<= 5.9) to <= 5.0 since there wont be any new 5.x versions after 5.0.