New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: lightdm-web-greeter (3.0.0rc2) #43536
[WIP]: lightdm-web-greeter (3.0.0rc2) #43536
Conversation
FWIW, I was/am testing using this mess: The (Sharing here as a question was asked on #nixos.) |
Hi, there was a question that somehow disappeared?.
It was tested up to lightdm-web-greeter starting. I haven't confirmed login worked, but I'm confident it should. Though this confidence is breached by the fact that the shutdown and reboot actions didn't work. I wouldn't upstream this as-it-is to nixpkgs because of the previous reasons, things are still in development, but once they deem a release to be stable, it would be eventually updated and merged. |
Hi ! I deleted my question as i read the topic, i guess i'll wait for a little more stable version. Keep up, and thanks for the answer ! |
Tried running it with |
Closing
Anyone is free to revitalize this PR from whichever fork of a web greeter replaces it. |
Motivation for this change
This is PRed for visibility. I have seen a couple of times people ask about lightdm-web-greeter. This is not ready to merge, though it works. This will give a hand to anyone trying to use or contribute lightdm-web-greeter, as they are bound to find this PR.
Why 3.0.0rc2 and not stable 2.2.5?
I did an initial try in the past, for the 2.x branch. It will not work with nixos. It seems that there is a bug with the way webkitgtk is packaged for NixOS, and local files are not rendered as html, but as plain text. This seems to also affect gnucash and the same bug did affect midori's DOM inspector during at least 17.09's lifetime.
Why isn't this PR for 3.0.0rc2 finished?
Well, first thing first, the code quality for the module hasn't been reviewed; this is a port from a module I wrote about a year ago, which was basically a copy of the ligthdm-gtk-greeter module. I would also need to take a couple minutes to review the derivations, but I think they're in mostly good standing.
Then, there's the issue of "rc2" It has been tagged 6 months ago, on the 8th of January. I would much prefer if they tagged a stable release. Though, there is some activity in the repo, so they eventually will.
Finally, the main reason I'm not continuing: I'm not sure about the quality of the implementation of that greeter. Maybe it's lightdm's configuration at fault, and not the web greeter, but it seems a bit buggy. The shutdown/reboot buttons do nothing (inside a nixos-rebuild build-vm). There are also some layout issue in the default theme, but that's probably not as much an issue.
I'm more concerned with the current state of their whither library, which I had to patch to work around (their quote) "broke[n] file::// url access in qt 5.11". I had to basically remove a bit of security from the library for it to work. That's not good. Until that is resolved, I may continue on and off (mostly off) to polish this, but this isn't worthy yet for inclusion.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)