Improve realloc on fixed buffer allocator #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If so extend that block instead of allocating a new one.
|
Related: #382 It would be great if we could get comptime code execution to support this with no modifications to your implementation. Maybe at comptime we could model pointers like this as opaque values but that are comparable, or something like that. Now that I'm thinking about it, I think I could get it to work in a reasonable way without too much code reworking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through the code and figured this would be useful.
The FixedBufferAllocator now checks if the memory buffer you pass into realloc is at the end of the used memory and just extends it instead of always allocating a new block.