Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 67.0.3396.87 -> 67.0.3396.99 #43539

Merged
merged 2 commits into from Jul 15, 2018
Merged

chromium: 67.0.3396.87 -> 67.0.3396.99 #43539

merged 2 commits into from Jul 15, 2018

Conversation

YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Jul 14, 2018 •
edited

Motivation for this change

New stable version with some minor fixes is out for quite some time (20 days), so stable bump is long overdue.

Also fix issues with Beta (68) and Dev (69).

I checked out resulting Stable, Beta and Dev binaries by watching some YouTube with them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@YorikSar
chromium: 67.0.3396.87 -> 67.0.3396.99
c283323
@YorikSar
chromium: fix 68 (beta) build
06ec2a9 
Also replace openh264 patch with one landed in upstream.
@fpletz fpletz merged commit c673643 into NixOS:master Jul 15, 2018
@YorikSar
Copy link
Contributor Author

@fpletz Thanks! Could you please merge this in release-18.03 as well?

@YorikSar
Copy link
Contributor Author

@bendlas Sorry, forgot to CC you here. I'm still confused as to who to CC on changes to packages...

@bendlas
Copy link
Contributor

bendlas commented Jul 16, 2018

@YorikSar No worries. When I tried to do the update, last week or so, google has had another case of missing .tar.xz. I should have created a WIP PR right there, but since there didn't seem to be any CVEs, I instead left it in a stash, which I just re-tried. I then pushed that commit to my fork before rebasing (and hence notifying you before noticing your update), because I had already built the system and wanted to install it.
Sorry for spamming you and thanks for keeping an eye on chromium.

@YorikSar
Copy link
Contributor Author

@bendlas Ok, good. I though I made you do extra work by not including you in CC here. I actually was gathering my thoughts about fixing beta/dev for quite some time now. I was afraid that again beta will be promoted, Chromium won't be ready in NixOS and I'll have to sit without new Chrome again :)

@YorikSar YorikSar mentioned this pull request Jul 27, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YorikSar @bendlas @fpletz @GrahamcOfBorg