Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cura: 3.3.1 -> 3.4.1 #43541

Merged
merged 5 commits into from Jul 15, 2018
Merged

cura: 3.3.1 -> 3.4.1 #43541

merged 5 commits into from Jul 15, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update and fix build of libarcus.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @abbradar

@jfrankenau jfrankenau requested a review from FRidh as a code owner July 14, 2018 20:59
@jfrankenau jfrankenau mentioned this pull request Jul 15, 2018
Closed
@fpletz fpletz merged commit d34cc21 into NixOS:master Jul 15, 2018
@jfrankenau jfrankenau deleted the update-cura branch July 16, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jfrankenau @fpletz @GrahamcOfBorg