Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_10: remove cache artificates (closure size reduction) #43504

Merged
merged 2 commits into from Jul 14, 2018
Merged

go_1_10: remove cache artificates (closure size reduction) #43504

merged 2 commits into from Jul 14, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 14, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Jul 14, 2018
Closed
@Mic92
Copy link
Member Author

Mic92 commented Jul 14, 2018

Both changes are safe to be back ported.

@Mic92
Copy link
Member Author

Mic92 commented Jul 14, 2018

@GrahamcOfBorg build go_1_10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go_1_10

Partial log (click to expand)

cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/kar43m349m9mk4d62h069zyfrpb2dnir-go-1.10.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go_1_10

Partial log (click to expand)

cannot find section .dynamic
cannot find section .dynamic
wrong ELF type
wrong ELF type
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/qlwgdxhph3n3vssv52zd99w79nj4s1f0-go-1.10.3

@xeji
Copy link
Contributor

xeji commented Jul 14, 2018

What's the connection between go closure size reduction and iana-etc ?

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: go_1_10, iana-etc

Partial log (click to expand)

/nix/store/qlwgdxhph3n3vssv52zd99w79nj4s1f0-go-1.10.3
/nix/store/kw0m9cqlm634wj8fkb4nddwazwinx9jk-iana-etc-20180711

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: go_1_10

Partial log (click to expand)


ALL TESTS PASSED
---
Installed Go for darwin/amd64 in /nix/store/5x4ql4k6akj70qxrchfavgdmcb9s8xy8-go-1.10.3/share/go
Installed commands in /nix/store/5x4ql4k6akj70qxrchfavgdmcb9s8xy8-go-1.10.3/share/go/bin
post-installation fixup
strip is /nix/store/7ddbq63v97nk8gkbf7gcsfmby37h6gbl-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5x4ql4k6akj70qxrchfavgdmcb9s8xy8-go-1.10.3/bin
patching script interpreter paths in /nix/store/5x4ql4k6akj70qxrchfavgdmcb9s8xy8-go-1.10.3
/nix/store/5x4ql4k6akj70qxrchfavgdmcb9s8xy8-go-1.10.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: go_1_10, iana-etc

Partial log (click to expand)

/nix/store/5x4ql4k6akj70qxrchfavgdmcb9s8xy8-go-1.10.3
/nix/store/96f2a2gv9cdvwqc884qqklaywmqb2qmf-iana-etc-20180711

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: go_1_10, iana-etc

Partial log (click to expand)

cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
cannot find section .dynamic
/nix/store/kar43m349m9mk4d62h069zyfrpb2dnir-go-1.10.3
/nix/store/g2xka6xihkwn6ibh925w4vrprlnrm6bj-iana-etc-20180711

@orivej
Copy link
Contributor

orivej commented Jul 14, 2018

This looks good, except for unrelated iana-etc change.

@Mic92 Mic92 merged commit d22cb7a into NixOS:master Jul 14, 2018
@Mic92
Copy link
Member Author

Mic92 commented Jul 14, 2018

I added the iana-etc update, because updating iana-etc will also trigger a go rebuild.
Usually there is only little change in the data so I update iana-etc only infrequently despite the many automatic releases in my repository.

@Mic92 Mic92 deleted the slim-go branch July 14, 2018 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @xeji @orivej