apple/macbookpro/11-5: init #68
Conversation
|
Also added a fix for a spurious wakeup signal that I judged to be important enough to include in this initial PR. |
rehno-lindeque
force-pushed
the
apple/macbookpro/11-5/init
branch
from
6140920
to
9ac18df
Compare
apple/macbook-pro/11-5/default.nix
Outdated
| <nixpkgs/nixos/modules/hardware/network/broadcom-43xx.nix> | ||
| ]; | ||
|
|
||
| boot.loader.systemd-boot.enable = true; |
There was a problem hiding this comment.
I think mkDefault should be used for boolean options: https://github.com/NixOS/nixos-hardware/pull/67/files#diff-0660552a9aaaac3267076efad7bf5c1bR9
There was a problem hiding this comment.
Fair enough, seems reasonable to make this optional.
apple/macbook-pro/11-5/default.nix
Outdated
| ]; | ||
|
|
||
| boot.loader.systemd-boot.enable = true; | ||
| boot.loader.efi.canTouchEfiVariables = true; |
There was a problem hiding this comment.
This should be only done for the first installation. Otherwise a new boot entry is created for every nixos-rebuild switch. This can fill up the nvram, which is also limited in terms of write-cycles.
There was a problem hiding this comment.
Interesting, thank you. How about if I put these two lines as instructions in the README.md file instead?
I suppose macbook-pro/10-1 could also do with a PR to fix.
Would be nice to update the docs too.
There was a problem hiding this comment.
Are these instructions better suited? https://nixos.wiki/wiki/Bootloader#Keeping_kernels.2Finitrd_on_the_main_partition
There was a problem hiding this comment.
Ok, sorry for the noise: Seeing as this config is already automatically generated by nixos-generate-config I suppose it really shouldn't be in this module at all.
I'll remove the boot loader completely if there's no objections.
rehno-lindeque
force-pushed
the
apple/macbookpro/11-5/init
branch
from
9ac18df
to
93c0fec
Compare
|
Looks good. Only merge conflicts needs to be resolved. |
rehno-lindeque
force-pushed
the
apple/macbookpro/11-5/init
branch
2 times, most recently
from
f33db96
to
f0ffb9f
Compare
As suggested by issue NixOS#41.
.wiki is just plain distracting to edit, markdown allows me to quickly write up accompanying docs.
Since the boot loader is already automatically generated by nixos-generate-config, there is no need to include it here.
rehno-lindeque
force-pushed
the
apple/macbookpro/11-5/init
branch
from
f0ffb9f
to
a9f65b8
Compare
|
OK, that ought do it |
Similar to macbookpro/10-1 and macbookpro/12-1.
Includes (minimal) external wiki references as suggested by #41, but this commit can be dropped if it is considered out of scope.