Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skypeforlinux: 8.18.06 -> 8.20.0.9 #43956

Closed
wants to merge 1 commit into from
Closed

skypeforlinux: 8.18.06 -> 8.20.0.9 #43956

wants to merge 1 commit into from

Conversation

zgrannan
Copy link
Contributor

Motivation for this change

skypeforlinux currently does not build (for me) on 18.03. It appears that the root cause is that Skype version 8.18.06 is no longer available in the Skype repo here: https://repo.skype.com/deb/pool/main/s/skypeforlinux/. Therefore, I've changed the version to the next version available in that repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@rycee
Copy link
Member

rycee commented Jul 23, 2018

I suspect it's best to instead cherry-pick the updates from master, if possible. It does seem to have additional changes but perhaps those would work for 18.03 as well?

@rycee
Copy link
Member

rycee commented Jul 23, 2018

Gave it a try and can confirm that cherry-picking the commits from master works. I'll push it to the release-18.03 branch.

@rycee
Copy link
Member

rycee commented Jul 23, 2018

Updated now.

@zgrannan Thanks for the PR and the reminder to update Skype :-)

@rycee rycee closed this Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zgrannan @rycee @GrahamcOfBorg