Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python packages: major updates #43972

Merged
merged 238 commits into from Jul 26, 2018
Merged

Python packages: major updates #43972

merged 238 commits into from Jul 26, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jul 22, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh FRidh merged commit 38ac3b3 into staging Jul 26, 2018
@dotlambda
Copy link
Member

dotlambda commented Jul 27, 2018

@FRidh I'm sorry, I was away for a few days and forgot to revert the spyder changes daabcc3 and 48eb8c4.

@FRidh
Copy link
Member Author

FRidh commented Jul 27, 2018

@dotlambda actually I removed them and rebased. I don't think the change would have brought us anything, really. Just work for those that had to change their expression.

@andreabedini
Copy link
Contributor

This broke aws-sam-cli which relies on aws-sam-translator == 1.6.0 (which this PR updates to 1.6.1). Since I contributed the initial derivation for aws-sam-cli, I'm keen to fix the build but ... how?

@dotlambda
Copy link
Member

@andreabedini I think the simplest thing is to add a postPatch hook, where you use substituteInPlace to replace ==1.6.0 by >=1.6.0. Plus, you should make upstream aware of it.

@andreabedini
Copy link
Contributor

@andreabedini I think the simplest thing is to add a postPatch hook, where you use substituteInPlace to replace ==1.6.0 by >=1.6.0. Plus, you should make upstream aware of it.

thanks @dotlambda, I will try that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants