cntlm: add support for darwin #43993
Conversation
GrahamcOfBorg
added
6.topic: darwin
|
@GrahamcOfBorg build cntlm |
|
Success on x86_64-darwin (full log) Attempted: cntlm Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: cntlm Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: cntlm Partial log (click to expand)
|
| CXX = "clang++"; | ||
| CC = "clang"; | ||
| CPP = "clang -E"; | ||
| CXXCPP = "clang++ -E"; |
There was a problem hiding this comment.
Should CXX/CC not be set by default? If CPP = "cpp"; CXXCPP = "cpp"; also works the platform condition could be removed.
cc @LnL7
There was a problem hiding this comment.
The CPP variants are not, the others are set by default yes.
There was a problem hiding this comment.
I think the best is do as @Mic92 points out and remove the platform condition. Thanks for reviewing!
| @@ -11,6 +11,11 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| buildInputs = [ which ]; | |||
|
|
|||
| preConfigure = stdenv.lib.optionalString stdenv.isDarwin '' | |||
| sed -e 's/gcc/clang/' Makefile > Makefile.clang | |||
There was a problem hiding this comment.
Note that makeFlags=["CC=cc"]; also should override the compiler. I am not sure if this applies here.
There was a problem hiding this comment.
Is this required in the presence of? https://github.com/framon/cntlm/blob/master/configure#L48
There was a problem hiding this comment.
Will look into the configure script @Mic92, thanks for pointing it out :)
I tried makeFlags=["CC=cc"]; but that didn't work. I think it's because the configure script is somehow unsetting the CC env var.
|
Cleaned it up a little bit, @Mic92. Check it out when you get a chance :) Thanks! |
Motivation for this change
Hi all,
This adds Darwin support to cntlm 馃槃
Thanks
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)