Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sieve-connect: Init at 0.89 #43976

Merged
merged 1 commit into from Jul 26, 2018
Merged

sieve-connect: Init at 0.89 #43976

merged 1 commit into from Jul 26, 2018

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Jul 22, 2018

Motivation for this change

I use this tool to administrate the mail rules on my mail server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dasJ
Copy link
Member Author

dasJ commented Jul 22, 2018

Failing check is unrelated

@FRidh
Copy link
Member

FRidh commented Jul 22, 2018

@GrahamcOfBorg eval

ryantm
ryantm requested changes Jul 24, 2018
View reviewed changes
pkgs/applications/networking/sieve-connect/default.nix Outdated
name = "sieve-connect-${version}";
version = "0.89";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub instead of fetchurl because it relies on the hash of the contents of the repository instead of the hash of a tarball, and it would allow us to fix all GitHub src fetchers, if GitHub changes something about how it works.

pkgs/applications/networking/sieve-connect/default.nix Outdated
as specifed in RFC 5804. Historically, this was MANAGESIEVE as
implemented by timsieved in Cyrus IMAP.
'';
homepage = "https://github.com/philpennock/sieve-connect";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quotes are not needed around URLs

@ryantm
Copy link
Member

ryantm commented Jul 24, 2018

@GrahamcOfBorg build sieve-connect

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sieve-connect

Partial log (click to expand)

chmod +x "sieve-connect"
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hvk6v1w6zg8p5f4rpma28nhs2335w3k7-sieve-connect-0.89
gzipping man pages under /nix/store/hvk6v1w6zg8p5f4rpma28nhs2335w3k7-sieve-connect-0.89/share/man/
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hvk6v1w6zg8p5f4rpma28nhs2335w3k7-sieve-connect-0.89/bin
patching script interpreter paths in /nix/store/hvk6v1w6zg8p5f4rpma28nhs2335w3k7-sieve-connect-0.89
checking for references to /build in /nix/store/hvk6v1w6zg8p5f4rpma28nhs2335w3k7-sieve-connect-0.89...
/nix/store/hvk6v1w6zg8p5f4rpma28nhs2335w3k7-sieve-connect-0.89

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sieve-connect

Partial log (click to expand)

chmod +x "sieve-connect"
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9lzimdlvh31rl6qdz0fdsz4hhxi8b7dk-sieve-connect-0.89
gzipping man pages under /nix/store/9lzimdlvh31rl6qdz0fdsz4hhxi8b7dk-sieve-connect-0.89/share/man/
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9lzimdlvh31rl6qdz0fdsz4hhxi8b7dk-sieve-connect-0.89/bin
patching script interpreter paths in /nix/store/9lzimdlvh31rl6qdz0fdsz4hhxi8b7dk-sieve-connect-0.89
checking for references to /build in /nix/store/9lzimdlvh31rl6qdz0fdsz4hhxi8b7dk-sieve-connect-0.89...
/nix/store/9lzimdlvh31rl6qdz0fdsz4hhxi8b7dk-sieve-connect-0.89

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: sieve-connect

Partial log (click to expand)

build flags: SHELL=/nix/store/ryb1pmpqm7xiznq5574lifykqrr30hg6-bash-4.4-p23/bin/bash
sed <"sieve-connect.pl" >"sieve-connect" "1s:/.*:`sh ./find-perl58.sh`:"
chmod +x "sieve-connect"
installing
post-installation fixup
gzipping man pages under /nix/store/9nq7xmrvjapv8mam0zh979qmm25av0av-sieve-connect-0.89/share/man/
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/9nq7xmrvjapv8mam0zh979qmm25av0av-sieve-connect-0.89/bin
patching script interpreter paths in /nix/store/9nq7xmrvjapv8mam0zh979qmm25av0av-sieve-connect-0.89
/nix/store/9nq7xmrvjapv8mam0zh979qmm25av0av-sieve-connect-0.89

@dasJ
Copy link
Member Author

dasJ commented Jul 26, 2018

@ryantm Rebased and fixed

@ryantm
Copy link
Member

ryantm commented Jul 26, 2018

@GrahamcOfBorg build sieve-connect

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: sieve-connect

Partial log (click to expand)

sed <"sieve-connect.pl" >"sieve-connect" "1s:/.*:`sh ./find-perl58.sh`:"
chmod +x "sieve-connect"
pod2man -n "sieve-connect" -c '' -d "`cat datefile`" -r "`cat versionfile`" "sieve-connect.pl" >"sieve-connect.1"
installing
post-installation fixup
gzipping man pages under /nix/store/jrgf9yr5l3wy20qmmnhpyq733s7gh8xv-sieve-connect-0.89/share/man/
strip is /nix/store/sixx1lfy97125f6hxymbwn64cb8z62p3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jrgf9yr5l3wy20qmmnhpyq733s7gh8xv-sieve-connect-0.89/bin
patching script interpreter paths in /nix/store/jrgf9yr5l3wy20qmmnhpyq733s7gh8xv-sieve-connect-0.89
/nix/store/jrgf9yr5l3wy20qmmnhpyq733s7gh8xv-sieve-connect-0.89

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sieve-connect

Partial log (click to expand)

pod2man -n "sieve-connect" -c '' -d "`cat datefile`" -r "`cat versionfile`" "sieve-connect.pl" >"sieve-connect.1"
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r3130s616gha3igf60n239mx3jiwq7q5-sieve-connect-0.89
gzipping man pages under /nix/store/r3130s616gha3igf60n239mx3jiwq7q5-sieve-connect-0.89/share/man/
strip is /nix/store/a245zacjzf3qw0davhvlfarihcy2yyrc-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r3130s616gha3igf60n239mx3jiwq7q5-sieve-connect-0.89/bin
patching script interpreter paths in /nix/store/r3130s616gha3igf60n239mx3jiwq7q5-sieve-connect-0.89
checking for references to /build in /nix/store/r3130s616gha3igf60n239mx3jiwq7q5-sieve-connect-0.89...
/nix/store/r3130s616gha3igf60n239mx3jiwq7q5-sieve-connect-0.89

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sieve-connect

Partial log (click to expand)

pod2man -n "sieve-connect" -c '' -d "`cat datefile`" -r "`cat versionfile`" "sieve-connect.pl" >"sieve-connect.1"
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d9q8j61syrlri024k3gs6nyf3yri22f3-sieve-connect-0.89
gzipping man pages under /nix/store/d9q8j61syrlri024k3gs6nyf3yri22f3-sieve-connect-0.89/share/man/
strip is /nix/store/a3nk8z2i7m7wa3jdckgv710n7j3yx4b5-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d9q8j61syrlri024k3gs6nyf3yri22f3-sieve-connect-0.89/bin
patching script interpreter paths in /nix/store/d9q8j61syrlri024k3gs6nyf3yri22f3-sieve-connect-0.89
checking for references to /build in /nix/store/d9q8j61syrlri024k3gs6nyf3yri22f3-sieve-connect-0.89...
/nix/store/d9q8j61syrlri024k3gs6nyf3yri22f3-sieve-connect-0.89

@ryantm ryantm merged commit 6d2ab18 into NixOS:master Jul 26, 2018
@ryantm
Copy link
Member

ryantm commented Jul 26, 2018

Thanks!

@dasJ dasJ deleted the sieve-connect branch July 26, 2018 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @FRidh @ryantm @GrahamcOfBorg