Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mupdf: fix on darwin #43988

Merged
merged 1 commit into from Jul 23, 2018
Merged

mupdf: fix on darwin #43988

merged 1 commit into from Jul 23, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 22, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

The fix for non-freglut is from upstream: http://git.ghostscript.com/?p=mupdf.git;a=blob;f=platform/gl/gl-ui.c;h=7ce94500922f5b8158fba2db484fb13a202fb272;hb=HEAD

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mupdf

Partial log (click to expand)

these paths will be fetched (19.89 MiB download, 44.15 MiB unpacked):
  /nix/store/4bb1zfnjfbz0xw9bnbaszdy7hgj2wycs-jbig2dec-0.14
  /nix/store/z1n0nwrrnf75k87gjczc8qxagd7k3ry9-mupdf-1.13.0
  /nix/store/zq1kc8h9y8qzvpyr722wlxym3m1fmdn1-mupdf-1.13.0-bin
copying path '/nix/store/4bb1zfnjfbz0xw9bnbaszdy7hgj2wycs-jbig2dec-0.14' from 'https://cache.nixos.org'...
copying path '/nix/store/z1n0nwrrnf75k87gjczc8qxagd7k3ry9-mupdf-1.13.0' from 'https://cache.nixos.org'...
copying path '/nix/store/zq1kc8h9y8qzvpyr722wlxym3m1fmdn1-mupdf-1.13.0-bin' from 'https://cache.nixos.org'...
/nix/store/zq1kc8h9y8qzvpyr722wlxym3m1fmdn1-mupdf-1.13.0-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mupdf

Partial log (click to expand)

these paths will be fetched (19.70 MiB download, 43.72 MiB unpacked):
  /nix/store/hldwrc59jndh2qypkgnwrwvf9fq93dbl-mupdf-1.13.0
  /nix/store/j8d0pf494z70qpcnk8xxp7cg0pnc8lrl-jbig2dec-0.14
  /nix/store/vkla3719qyi4lmbc2kkdv62wa1c2c9jb-mupdf-1.13.0-bin
copying path '/nix/store/j8d0pf494z70qpcnk8xxp7cg0pnc8lrl-jbig2dec-0.14' from 'https://cache.nixos.org'...
copying path '/nix/store/hldwrc59jndh2qypkgnwrwvf9fq93dbl-mupdf-1.13.0' from 'https://cache.nixos.org'...
copying path '/nix/store/vkla3719qyi4lmbc2kkdv62wa1c2c9jb-mupdf-1.13.0-bin' from 'https://cache.nixos.org'...
/nix/store/vkla3719qyi4lmbc2kkdv62wa1c2c9jb-mupdf-1.13.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: mupdf

Partial log (click to expand)

patching script interpreter paths in /nix/store/hpgbir28njdginb3d2dcq6n4f1ja8bi5-mupdf-1.13.0-dev
strip is /nix/store/qvj6bdvy7vdaxi3my0nq8ghf14njh8wk-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/kjarpxkpwvy1640ijvc13qdhaimrq3yk-mupdf-1.13.0/lib
patching script interpreter paths in /nix/store/kjarpxkpwvy1640ijvc13qdhaimrq3yk-mupdf-1.13.0
gzipping man pages under /nix/store/93l2i80gzgk6aql4vv094d2q4i6vg6dd-mupdf-1.13.0-man/share/man/
strip is /nix/store/qvj6bdvy7vdaxi3my0nq8ghf14njh8wk-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/93l2i80gzgk6aql4vv094d2q4i6vg6dd-mupdf-1.13.0-man
strip is /nix/store/qvj6bdvy7vdaxi3my0nq8ghf14njh8wk-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/p0nfiqqsjp1x5sq5vjkn47gf2krkrznc-mupdf-1.13.0-doc
/nix/store/4ndzkda7crk7dvq668jxrhkwjkw1ilhv-mupdf-1.13.0-bin

@vbgl vbgl merged commit d4d5f8e into NixOS:master Jul 23, 2018
@veprbl veprbl deleted the pr/mupdf_1.13_darwin_fix branch December 1, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @GrahamcOfBorg @vbgl