Bug 1458850 - Don't retry tasks that throw a KeyError #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
suggested changes
Jul 23, 2018
treeherder/workers/task.py
Outdated
| @@ -23,6 +23,7 @@ class retryable_task(object): | |||
| jsonschema.ValidationError, | |||
| # eg during log decompression | |||
| zlib.error, | |||
| KeyError, | |||
There was a problem hiding this comment.
Could you move this up with the other built-in exceptions? (Or else perhaps we should just sort this alphabetically?)
There was a problem hiding this comment.
Sure thing, I've sorted (case-insensitively) and rebased into this commit.
edmorley
approved these changes
Jul 23, 2018
ghickman
force-pushed
the
stop-keyerror-task-retrys
branch
from
9ed588d
to
86c1cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tells our
retryable_taskdecorator to not retry tasks that throw aKeyErrorsince that situation is unlikely to change on a retry.