Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37.pkgs.{pycodestyle,pyflakes,flake8,pystemmer} #44004

Merged
merged 2 commits into from Jul 23, 2018
Merged

python37.pkgs.{pycodestyle,pyflakes,flake8,pystemmer} #44004

merged 2 commits into from Jul 23, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jul 23, 2018 •
edited

Motivation for this change

flake8 was bumped to a pre-release since it already contains fixes for pyflakes, but the author is too busy making a new release. This fixes were required to get basic linter infrastructure ready for python37.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from FRidh as a code owner July 23, 2018 09:55
@Mic92 Mic92 changed the title Python37 fixes python37.pkgs.{pycodestyle,pyflakes,flake8,pystemmer} Jul 23, 2018
@Mic92
Copy link
Member Author

Mic92 commented Jul 23, 2018

I suppose this should be moved to staging (sphinx gets rebuild)

@Mic92 Mic92 changed the base branch from master to staging July 23, 2018 10:10
@GrahamcOfBorg GrahamcOfBorg added 6.topic: ruby 6.topic: stdenv Standard environment 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ and removed 6.topic: ruby 6.topic: stdenv Standard environment 6.topic: xfce The Xfce Desktop Environment labels Jul 23, 2018
FRidh
FRidh requested changes Jul 23, 2018
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on top of python-unstable branch.

@FRidh
Copy link
Member

FRidh commented Jul 23, 2018

Note I fixed flake8 on that branch already.

@FRidh
Copy link
Member

FRidh commented Jul 23, 2018

@dotlambda is being thorough 4741811
(I have no preference regarding the solutions)

@Mic92 Mic92 changed the base branch from staging to python-unstable July 23, 2018 10:51
@Mic92
Copy link
Member Author

Mic92 commented Jul 23, 2018

The remaining changes are trivial.

@Mic92 Mic92 merged commit cb37c93 into NixOS:python-unstable Jul 23, 2018
@Mic92 Mic92 deleted the python37-fixes branch July 23, 2018 10:52
Mic92
Mic92 commented Jul 23, 2018
View reviewed changes
pkgs/development/python-modules/pystemmer/default.nix
nativeBuildInputs = [ cython ];

preBuild = ''
cython src/Stemmer.pyx
Copy link
Member Author

@Mic92 Mic92 Jul 23, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope we do not add cython to some critical dependency chains though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should not be the case.

Their setup.py doesn't automatically compile it when cython is present?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory yes. I will try to remove preBuild: https://github.com/snowballstem/pystemmer/blob/master/setup.py#L46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @FRidh @GrahamcOfBorg