Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elpa: fix evaluation #43998

Closed
wants to merge 1 commit into from
Closed

elpa: fix evaluation #43998

wants to merge 1 commit into from

Conversation

periklis
Copy link
Contributor

Motivation for this change

This commit 52f53c6#diff-042e9fdbafb1ed159eb334bd5f71c0c1L3

broke the evaluation of the elpa builder

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@periklis
Copy link
Contributor Author

periklis commented Jul 23, 2018 •
edited

ping @volth @ttuegel @Mic92

@adisbladis
Copy link
Member

Sorry I didn't check for a PR before pushing. Thanks @periklis!

@adisbladis adisbladis closed this Jul 23, 2018
@periklis
Copy link
Contributor Author

@adisbladis No problem! :)

@periklis periklis deleted the fix-eval-elpa-builder branch July 23, 2018 09:33
@periklis periklis mentioned this pull request Jul 23, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @adisbladis @GrahamcOfBorg