Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pyyaml: 3.12 -> 3.13 #43961

Merged
merged 1 commit into from Jul 22, 2018
Merged

python.pkgs.pyyaml: 3.12 -> 3.13 #43961

merged 1 commit into from Jul 22, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner July 22, 2018 07:45
@FRidh
Copy link
Member

FRidh commented Jul 22, 2018

I think it is time for a batch upgrade again. Not sure whether to do major updates or stick with just patch updates.

@dotlambda
Copy link
Member Author

Yes, it is. When was the last time you did major upgrades?

@dotlambda
Copy link
Member Author

Btw, I'd like to merge this one into master because it's required for a Home Assistant upgrade.

@FRidh
Copy link
Member

FRidh commented Jul 22, 2018

Yes, that's ok. Go for it.

@dotlambda dotlambda merged commit 3a0c4a8 into NixOS:master Jul 22, 2018
@dotlambda dotlambda deleted the pyyaml-3.13 branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @FRidh @GrahamcOfBorg