Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops
base: ceaafbd9b725
Choose a base ref
...
head repository: NixOS/nixops
compare: d4e5b779def1
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 15, 2018

  1. nixops script: Remove top-level Exception catch-all.

    Having this catch-all made it difficult to develop and troubleshoot
    nixops.
    
    For example, when adding a new backend and forgetting to add the
    corresponding `option` in the `.nix` file, nixops would die simply
    with
    
        error: 'serverType'
    
    which is not a good indication over what went wrong.
    Specifically so because `error(str(e))` removed the type of the
    exception, turning `KeyError: 'serverType'` into just `serverType`.
    
    So far, you could pass `--show-trace` or `--debug` to see
    Python stack traces.
    However, that requires the error to be easily reproducible
    (when you see it, you have to run again with `--show-trace`),
    making debugging of rare problems hard.
    
    For an ops tool we should make debugging of rare/unknown
    problems as easy as possible.
    Consequently, this commit makes Python raise the `Exception`
    with stack trace if we have no idea at all what the exception
    type is.
    
    The other cases (when we know what exception type it is)
    remain unaffected.
    nh2 committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    a020907 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. Merge pull request #924 from nh2/no-top-level-exception-catch-all

    nixops script: Remove top-level Exception catch-all.
    domenkozar committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    d4e5b77 View commit details
    Browse the repository at this point in the history