Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.doctest-discover: Disable tests #43959

Merged
merged 1 commit into from Jul 23, 2018
Merged

haskellPackages.doctest-discover: Disable tests #43959

merged 1 commit into from Jul 23, 2018

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Jul 22, 2018

Motivation for this change

The source package is missing a required file. See:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@endgame endgame requested a review from peti as a code owner July 22, 2018 07:14
@nh2
Copy link
Contributor

nh2 commented Jul 22, 2018

Process question: How do we remind ourselves to remove this again once upstream has patched the problem?

@endgame
Copy link
Contributor Author

endgame commented Jul 22, 2018 •
edited

I'm subscribed to both upstream bugs, so I can revert this. Not sure about the general case.

@endgame
Copy link
Contributor Author

endgame commented Jul 23, 2018 •
edited

doctest-discover-0.2.0.0 has hit hackage, so if we get a hackage snapshot update before this merges, this PR becomes redundant.

@endgame
Copy link
Contributor Author

endgame commented Jul 23, 2018

I note that doctest-discover is currently pinned in configuration-hackage2nix.yaml, so I guess we have to wait for stackage to update, then update nixpkgs to pick this up?

@basvandijk
Copy link
Member

Note that doctest-discover_0_2_0_0 is already in haskell-updates.

@endgame
Copy link
Contributor Author

endgame commented Jul 23, 2018

That's handy, but this package is still unbuildable. It's a bit silly to offer it.

@basvandijk basvandijk merged commit 3d4ea59 into NixOS:master Jul 23, 2018
@basvandijk
Copy link
Member

basvandijk commented Jul 23, 2018 •
edited

@endgame thanks!

@nh2 to answer your question regarding process: I think we should go over all overrides periodically (ideally every time configuration-hackage2nix.yaml gets updated for a new LTS release) and see if the associated issues still hold.

@basvandijk
Copy link
Member

@endgame I did move the override from configuration-nix.nix to configuration-common.nix because the former is only for fixing build failures due to Nix. Also see the documentation on the top of that file.

@endgame
Copy link
Contributor Author

endgame commented Jul 24, 2018

@basvandijk Thank you. Should the blank-canvas fixes move across too, then? (They require a browser and do not run automatically.) If so, I will prepare another PR.

@endgame endgame deleted the dontCheck-doctest-discover branch July 24, 2018 00:12
@basvandijk
Copy link
Member

@endgame yes I think the blank-canvas overrides should move as well.

@endgame endgame mentioned this pull request Jul 24, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@endgame @nh2 @basvandijk @GrahamcOfBorg