Openssl in coreutils makes *sum programs much faster (RFC) #43983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sha256sum, md5sum, etc.
|
@GrahamcOfBorg eval |
GrahamcOfBorg
added
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
10.rebuild-darwin: 501+
10.rebuild-linux: 501+
and removed
6.topic: stdenv
| @@ -1,5 +1,6 @@ | |||
| { stdenv, lib, buildPackages | |||
| , autoreconfHook, texinfo, fetchurl, perl, xz, libiconv, gmp ? null | |||
| , openssl ? null | |||
There was a problem hiding this comment.
You shouldn't need the default. openssl will always be defined in a callPackage.
|
This adds about 3 MiB to the coreutils closure size. However, given that openssl is a pretty ubiquitous dependency anyway, that's probably not a big deal. |
Suggested by matthewbauer review.
|
Ok. I'll merge it when these automatic tests finish. |
|
Why was this merged to master instead of staging? |
|
Reverted in 0eb1316 since this broke stdenv and as a result, everything. FYI. |
dtzWill
added a commit
that referenced
this pull request
Jul 29, 2018
coreutils is part of stdenv, which doesn't allow openssl currently. It's unclear that adding openssl to stdenv was intended, but if it was it was not discussed or mentioned. To unbreak "all the things", reverting until this has been discussed and a proper fix has been put together. This reverts commit df9f76c, reversing changes made to 585ded7.
|
coreutils is part of stdenv. To build stdenv there is a pre-build bootstrap tarball. To use openssl in stdenv it also needs to be part of the boostraping, I think. |
|
would a stdenv.isLinux be enough? I don't know what's that Darwin condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sha256sum, md5sum,. run much faster. Factor 2x to 4x.
You can evaluate that by comparing the cpu time of your 'time sha256sum bigfile' and 'time openssl sha256 bigfile'.
What do you think? I use these a lot, and I guess that git-annex users too.