Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge run_wpt.py into run.py #21229

Merged
merged 1 commit into from Jul 23, 2018
Merged

Merge run_wpt.py into run.py #21229

merged 1 commit into from Jul 23, 2018

Conversation

ergunsh
Copy link
Contributor

@ergunsh ergunsh commented Jul 22, 2018

To ensure everything is still works, one can run ./mach test-wpt tests/wpt/mozilla/DOMParser.html


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Merge run.py with run_wpt.py #21201 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests

This change is Reviewable

@highfive
Copy link

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/testing_commands.py
  • @jgraham: tests/wpt/run_wpt.py, tests/wpt/run.py, tests/wpt/README.md

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 22, 2018
@jdm
Copy link
Member

jdm commented Jul 22, 2018

@bors-servo r+
Thanks!

@bors-servo
Copy link
Contributor

📌 Commit ae20469 has been approved by jdm

@highfive highfive assigned jdm and unassigned nox Jul 22, 2018
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 22, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit ae20469 with merge 9a21acb...

bors-servo pushed a commit that referenced this pull request Jul 22, 2018
Merge run_wpt.py into run.py

<!-- Please describe your changes on the following line: -->
To ensure everything is still works, one can run `./mach test-wpt tests/wpt/mozilla/DOMParser.html`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21201 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21229)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 22, 2018
@bors-servo
Copy link
Contributor

⌛ Testing commit ae20469 with merge 8933a06...

bors-servo pushed a commit that referenced this pull request Jul 22, 2018
Merge run_wpt.py into run.py

<!-- Please describe your changes on the following line: -->
To ensure everything is still works, one can run `./mach test-wpt tests/wpt/mozilla/DOMParser.html`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21201 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21229)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jul 22, 2018
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-css2

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jul 22, 2018
@jdm
Copy link
Member

jdm commented Jul 23, 2018

@bors-servo retry

@bors-servo
Copy link
Contributor

@bors-servo
Copy link
Contributor

@bors-servo bors-servo merged commit ae20469 into servo:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-tests-failed The changes caused existing tests to fail.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge run.py with run_wpt.py
5 participants