Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 3 commits
- 7 files changed
- 1 contributor
Commits on Jul 23, 2018
-
Fail with an error if the set does not contain the binding we're tryi…
…ng to replace. The 'replace' function is used to fix bindings in 'Derivation' that the 'resolveInNixpkgs' lookup failed to figure out. Now, one problem we encountered is that the (bogus) binding we assumed to be there actually doesn't exist any more because Nixpkgs has changed, and in such a case 'replace' silently did nothing, resulting in a potentially broken build. Instead, we interpret "replace old new bs" to imply that "old `elem` bs" is true and fail if it's not to indicate that the post-process code must be adapted to the new situation.
-
Fix broken Nixpkgs resolver in cabal2nix.
Our Nixpkgs name resolver must return the top-level name 'foo' as 'pkgs.foo' because that is the path system packages have from the PoV of Haskell packages. We always did that in hackage2nix, but both cabal2nix and the regression tests were broken in that regard. Fixes #364.
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0e482ab4fda7...347581f88ebc