Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpv: 0.28.2 -> 0.29.0 #43977

Merged
merged 1 commit into from Jul 24, 2018
Merged

mpv: 0.28.2 -> 0.29.0 #43977

merged 1 commit into from Jul 24, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Jul 22, 2018

https://github.com/mpv-player/mpv/releases/tag/v0.29.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jul 22, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0
shrinking /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0/bin/.mpv-wrapped
shrinking /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0/lib/libmpv.so.1.101.0
gzipping man pages under /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0/share/man/
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0/lib  /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0/bin
patching script interpreter paths in /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0
checking for references to /build in /nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0...
/nix/store/jsmwzykwch7cppc20fz20y5myw6njcvj-mpv-0.29.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpv

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0
shrinking /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0/lib/libmpv.so.1.101.0
shrinking /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0/bin/.mpv-wrapped
gzipping man pages under /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0/share/man/
strip is /nix/store/h0nc84ybvb8g724fwysvcghh1675wjli-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0/lib  /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0/bin
patching script interpreter paths in /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0
checking for references to /build in /nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0...
/nix/store/5r7840v3nnqb6w32hwgla4dykagbl1wd-mpv-0.29.0

@Mic92
Copy link
Member

Mic92 commented Jul 23, 2018

mpc-qt seems to be broken, however this was already the case before this updated: https://hydra.nixos.org/build/75980372

@infinisil infinisil merged commit c9f4991 into NixOS:master Jul 24, 2018
@Enzime
Copy link
Member

Enzime commented Jul 25, 2018

@grahamc Why didn't this build on Darwin? This PR breaks mpv on Darwin 😞

@Mic92
Copy link
Member

Mic92 commented Jul 27, 2018

@GrahamcOfBorg build mpv

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mpv

Partial log (click to expand)

copying path '/nix/store/9rk31lmgmh3flci3lz6r13x5nf8n9yas-SDL2-2.0.8' from 'https://cache.nixos.org'...
copying path '/nix/store/hrhgh9jvkm92qcxsb350nxffiib9a4lg-libva-2.1.0' from 'https://cache.nixos.org'...
copying path '/nix/store/zpf8azra7anmidjs5pj78fd569p2pl2v-python2.7-setuptools-39.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/xr9gl5rjlw5sq5ynhqckwb7vjs4i97b9-ffmpeg-3.4.3' from 'https://cache.nixos.org'...
copying path '/nix/store/32v1vjn87gqyxpmgw6gz5lm2gigzjmz1-ffmpeg-4.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/pih27b9znsj04ldp6fcka941qvf7aphi-ffmpeg-3.4.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/l69k0kal5s0cc24i8v5m0kxn3ykv95h1-python2.7-pycryptodome-3.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/9rwhvf68pc6r4z5lx7h012rp33zl9x5g-python2.7-youtube-dl-2018.07.10' from 'https://cache.nixos.org'...
copying path '/nix/store/q5pcpkvkzl3p6fnvrz4r53jdsshmrnwi-mpv-0.29.0' from 'https://cache.nixos.org'...
/nix/store/q5pcpkvkzl3p6fnvrz4r53jdsshmrnwi-mpv-0.29.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mpv

Partial log (click to expand)

copying path '/nix/store/p0yj029991p4zjlr7d7rv9b7v8wnl6kz-libass-0.14.0' from 'https://cache.nixos.org'...
copying path '/nix/store/izp4b5aq3qhff9kcz9w94sgi9vll5ris-SDL2-2.0.8' from 'https://cache.nixos.org'...
copying path '/nix/store/nr67d5shy6fyg5lfyhgn7ddvl149fd77-ffmpeg-3.4.3' from 'https://cache.nixos.org'...
copying path '/nix/store/x946f4jvd613l3n6si2y3b8cnjn2pwzs-ffmpeg-4.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/dacw9rn8dn0rzjh5i85kfr8cbykx3xbi-python2.7-setuptools-39.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/zz4zi08a3czpyxzy8x8kb23zd4drqfyd-python2.7-pycryptodome-3.6.2' from 'https://cache.nixos.org'...
copying path '/nix/store/ipsx8065f21l616bzm9xp3mpalqadr72-ffmpeg-3.4.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/mrq905kvab3izzyiv1rb24shrq730jv1-python2.7-youtube-dl-2018.07.10' from 'https://cache.nixos.org'...
copying path '/nix/store/2yyw98rk6zplkgafq1dqsmhihzzyx0jw-mpv-0.29.0' from 'https://cache.nixos.org'...
/nix/store/2yyw98rk6zplkgafq1dqsmhihzzyx0jw-mpv-0.29.0

@Mic92
Copy link
Member

Mic92 commented Jul 27, 2018

Due to the missing sandbox on macOS only trusted user can start macOS builds.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: mpv

Partial log (click to expand)

[1/1] Compiling version.sh
[  2/418] Processing osdep/macOS_swift.o osdep/macOS_swift.h osdep/macOS_swift.swiftmodule: osdep/macOS_mpv_helper.swift video/out/cocoa-cb/events_view.swift video/out/cocoa-cb/video_layer.swift video/out/cocoa-cb/window.swift video/out/cocoa_cb_common.swift -> build/osdep/macOS_swift.o build/osdep/macOS_swift.h build/osdep/macOS_swift.swiftmodule
[  3/418] Compiling TOOLS/osxbundle/mpv.app/Contents/Resources/icon.icns
/bin/sh: []: command not found

Waf: Leaving directory `/private/tmp/nix-build-mpv-0.29.0.drv-0/source/build'
Build failed
 -> task in 'osdep/macOS_swift.o osdep/macOS_swift.h osdep/macOS_swift.swiftmodule' failed with exit status 127 (run with -v to display more information)
builder for '/nix/store/g4kxr9ii2548i8v8drkxm5z0m6zaw5mn-mpv-0.29.0.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/g4kxr9ii2548i8v8drkxm5z0m6zaw5mn-mpv-0.29.0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Jul 27, 2018

My wild guess is that the shebangs needs to be patched on macOS: https://github.com/mpv-player/mpv/blob/master/version.sh#L1

@Mic92 Mic92 mentioned this pull request Jul 27, 2018
Closed
9 tasks
@Mic92
Copy link
Member

Mic92 commented Jul 27, 2018

I tried to fix this here, but stuck without having macOS: #44147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dywedir @FRidh @GrahamcOfBorg @Mic92 @Enzime @infinisil