Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.4.2 -> 1.4.3 #43997

Closed
wants to merge 1 commit into from
Closed

gitea: 1.4.2 -> 1.4.3 #43997

wants to merge 1 commit into from

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Jul 23, 2018 •
edited

Motivation for this change

New version. Includes security bugfixes (might be worth backporting to stable)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@etu
Copy link
Contributor

etu commented Jul 23, 2018

Changelog here: https://github.com/go-gitea/gitea/releases/tag/v1.4.3

Since it contains security fixes it should probably be back-ported to stable as well.

@yrashk I always find it good to link to the changelog in the commit, in the comment section of the commit message or so (first line is header, second should be empty, third is start of the comment section).

@yrashk
Copy link
Contributor Author

yrashk commented Jul 23, 2018

@etu good idea, haven't thought about it! I'll do the next time. Or do you want me to amend this one?

@etu
Copy link
Contributor

etu commented Jul 23, 2018

@yrashk You can amend this one, people with the right's to merge (not me) won't complain about it being there since it's easier to look up why something was updated (more than newer versions is usually a good idea) just from reading the log 🙂

@yrashk
Copy link
Contributor Author

yrashk commented Jul 23, 2018

@etu amended

@etu
Copy link
Contributor

etu commented Jul 23, 2018

@GrahamcOfBorg build gitea

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

code.gitea.io/gitea/routers/api/v1/user
code.gitea.io/gitea/routers
code.gitea.io/gitea/routers/org
code.gitea.io/gitea/routers/api/v1/admin
code.gitea.io/gitea/routers/api/v1/org
code.gitea.io/gitea/routers/admin
code.gitea.io/gitea/routers/api/v1
code.gitea.io/gitea/routers/routes
builder for '/nix/store/1gnykrk5axfrgr76ymszpin02px7c0v3-gitea-1.4.3.drv' failed with exit code 43
error: build of '/nix/store/1gnykrk5axfrgr76ymszpin02px7c0v3-gitea-1.4.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

checking for references to /build in /nix/store/mj54p478a3f99jbk0gb6hyi4f7dnlkww-gitea-1.4.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/xqw745z4rdjb39sziskz2dd31d36f01r-gitea-1.4.3
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/xqw745z4rdjb39sziskz2dd31d36f01r-gitea-1.4.3
checking for references to /build in /nix/store/xqw745z4rdjb39sziskz2dd31d36f01r-gitea-1.4.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/b0gjd25qdd5q023ll4p6q4iw1nls8sps-gitea-1.4.3-data
strip is /nix/store/fzsyclvxz1p2ia83caniy93v8cwarg0j-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b0gjd25qdd5q023ll4p6q4iw1nls8sps-gitea-1.4.3-data
checking for references to /build in /nix/store/b0gjd25qdd5q023ll4p6q4iw1nls8sps-gitea-1.4.3-data...
/nix/store/mj54p478a3f99jbk0gb6hyi4f7dnlkww-gitea-1.4.3-bin

@Mic92
Copy link
Member

Mic92 commented Jul 23, 2018

Error on aarch64 looks temporary. The machine has 96-cores, which probably spawned to many compilation threads w.r.t. memory.

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jul 23, 2018
@danieldk
Copy link
Contributor

Note: duplicate of #43957.

@Mic92
Copy link
Member

Mic92 commented Jul 23, 2018

merged #43957

@Mic92 Mic92 closed this Jul 23, 2018
@Mic92 Mic92 mentioned this pull request Jul 23, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu etu approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yrashk @etu @GrahamcOfBorg @Mic92 @danieldk