Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sddm: 0.17.0 -> 0.18.0 #43978

Closed
wants to merge 1 commit into from
Closed

sddm: 0.17.0 -> 0.18.0 #43978

wants to merge 1 commit into from

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Jul 22, 2018

Motivation for this change

@adisbladis @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bkchr
Copy link
Contributor Author

bkchr commented Jul 22, 2018

This breaks the plasma5 test. I will first need to fix that!

@FRidh
Copy link
Member

FRidh commented Jul 22, 2018

@GrahamcOfBorg eval

@bkchr
Copy link
Contributor Author

bkchr commented Jul 23, 2018

Hmm, the OCR in the plasma5 test is breaking again... Anyone an idea how we could get the OCR back working?
Maybe we need to create our own SDDM theme, with a predefined font and colours that are good for OCR.

@worldofpeace
Copy link
Contributor

worldofpeace commented Jul 28, 2018

@bkchr I think that's a good idea. Also I noticed that sddm now when it's inactive hides the information the test would normally be looking for.

Edit: I think that might only be when you're already logged and it functions as a screensaver

@peterhoeg
Copy link
Member

@bkchr did you manage to get the tests to behave?

@bkchr
Copy link
Contributor Author

bkchr commented Sep 7, 2018

Sorry, did not had time yet to look into creating a custom theme :(

@dtzWill
Copy link
Member

dtzWill commented Sep 12, 2018

Beep boop? :)

@andrew-d andrew-d mentioned this pull request Sep 22, 2018
17 tasks
@dtzWill
Copy link
Member

dtzWill commented Sep 27, 2018

@GrahamcOfBorg test sddm

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.sddm

No partial log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.sddm

No partial log is available.

@bkchr
Copy link
Contributor Author

bkchr commented Sep 27, 2018

But the plasma test will fail.

@peterhoeg
Copy link
Member

I created a candidate for the world's ugliest theme for use with the plasma tests but I haven't tried it out yet. I'll give it a go this weekend.

@bkchr
Copy link
Contributor Author

bkchr commented Sep 27, 2018

Nice. It does not need to be beautiful :D If you want and you already have it online somewhere. I could test it for you.

@peterhoeg
Copy link
Member

That'd be great: https://gitlab.com/peterhoeg/sddm-high-contrast

@peterhoeg
Copy link
Member

Did you manage to get it working @bkchr?

@bkchr
Copy link
Contributor Author

bkchr commented Oct 1, 2018

Did not had time yet to test it. Sorry.

@bkchr bkchr mentioned this pull request Oct 28, 2018
9 tasks
@samueldr
Copy link
Member

@bkchr can you confirm (and close if so) that this is not needed anymore?

@peterhoeg
Copy link
Member

0.18 is already in unstable so this is safe to close.

@peterhoeg peterhoeg closed this Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants