Skarnet software: Rename attributes & split outputs #43980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Profpatsch
changed the title
|
@GrahamcOfBorg build skalibs s6-linux-utils execline s6-portable-utils s6-dns s6-networking s6-rc s6 |
|
Success on x86_64-linux (full log) Attempted: skalibs, s6-linux-utils, execline, s6-portable-utils, s6-dns, s6-networking, s6-rc, s6 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: skalibs, s6-linux-utils, execline, s6-portable-utils, s6-dns, s6-networking, s6-rc, s6 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: skalibs, execline, s6-portable-utils, s6-dns, s6-networking, s6 The following builds were skipped because they don't evaluate on x86_64-darwin: s6-linux-utils, s6-rc Partial log (click to expand)
|
|
@GrahamcOfBorg eval |
Mic92
reviewed
Jul 23, 2018
| <varname>s6LinuxUtils</varname> and <varname>s6PortableUtils</varname> | ||
| renamed to | ||
| <varname>s6-dns</varname>, <varname>s6-networking</varname>, | ||
| <varname>s6-linux-utils</varname> and <varname>s6-portable-utils</varname> respectively. |
There was a problem hiding this comment.
Should be pkgs/top-level/aliases.nix not more intuitive then reading release notes?
Change the attribute names of camelCased utils to kebab-case to improve consistency. Split every package into multiple outputs where possible.
Profpatsch
force-pushed
the
skarnet-outputs
branch
from
8d5b9a7
to
faee6b4
Compare
|
@GrahamcOfBorg build s6Dns s6Networking s6PortableUtils s6LinuxUtils |
|
Success on aarch64-linux (full log) Attempted: s6Dns, s6Networking, s6PortableUtils, s6LinuxUtils Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: s6Dns, s6Networking, s6PortableUtils The following builds were skipped because they don't evaluate on x86_64-darwin: s6LinuxUtils Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: s6Dns, s6Networking, s6PortableUtils, s6LinuxUtils Partial log (click to expand)
|
|
Huh, Since the other build on darwin was successful, I’ll assume this was just a temporary hickup of the build machine. |
|
I’d like to merge, any more comments? Vetoes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (rather large) PR adds multiple outputs to all skarnet.org software. It also renames the attribute names of muilti-word packages to be more consistent.
In the future it might make sense to write a
buildSkarnetPackagefunction to remove the duplication between most package derivations.cc maintainer @pmahoney