Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: fix build of all tensorflow packages #43970

Merged
merged 2 commits into from Jul 22, 2018
Merged

haskell: fix build of all tensorflow packages #43970

merged 2 commits into from Jul 22, 2018

Conversation

basvandijk
Copy link
Member

Motivation for this change

@peti I fixed the build of all the other TensorFlow haskell packages.

Note that this commit changes configuration-hackage2nix.yaml and requires a hackage-packages.nix upgrade again.

I also moved the tensorflow overrides out of configuration-ghc-8.2.x.nix and into the dedicated file configuration-tensorflow-ghc-8.2.x.nix for better readability.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@basvandijk
haskell: fix build of all tensorflow packages
e60f4ee 
* Since this commit changes configuration-hackage2nix.yaml it
  requires a hackage-packages.nix upgrade.

* Moved the tensorflow overrides out of configuration-ghc-8.2.x.nix
  and into the dedicated file configuration-tensorflow-ghc-8.2.x.nix
  for better readability.

* Add overrides for all the packages in the tensorflow-haskell
  repository.
@basvandijk basvandijk requested a review from peti as a code owner July 22, 2018 14:40
@basvandijk
hackage-packages.nix: automatic Haskell package set update
0ac253d 
This update was generated by hackage2nix v2.10.1-8-gd90c8cc from Hackage revision
commercialhaskell/all-cabal-hashes@f98093e.
@peti peti merged commit 810c3e3 into NixOS:master Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@basvandijk @peti @GrahamcOfBorg