Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rdma-core: 17.1 -> 19 #43357

Merged
merged 1 commit into from Jul 11, 2018
Merged

rdma-core: 17.1 -> 19 #43357

merged 1 commit into from Jul 11, 2018

Conversation

markuskowa
Copy link
Member

Motivation for this change

Update package.

@ryantm is it possible to add that package to you auto updater?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
    nixbuild nixos/tests/rxe.nix succeeds
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
    All packages build successfully
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    ~ +60kB
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Jul 11, 2018

@markuskowa It is in there, but it was failing to upgrade it because it was trying to upgrade the version to "19.0" instead of "19". It was getting that from Debian/Ubuntu ( https://repology.org/metapackage/rdma-core/versions ) who have mangled the version string.

@ryantm ryantm mentioned this pull request Jul 11, 2018
Closed
@xeji
Copy link
Contributor

xeji commented Jul 11, 2018

@GrahamcOfBorg build rdma-core

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rdma-core

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rdma-core

Partial log (click to expand)

patching script interpreter paths in /nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19
/nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/bin/rxe_cfg: interpreter directive changed from "/usr/bin/perl" to "/nix/store/vawc9a89l53mf05yq0k1910q7dakd99w-perl-5.24.3/bin/perl"
/nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/sbin/srp_daemon.sh: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/libexec/srp_daemon/start_on_all_ports: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/libexec/truescale-serdes.cmds: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/etc/init.d/srpd: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/etc/init.d/ibacm: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
/nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/etc/init.d/iwpmd: interpreter directive changed from "/bin/bash" to "/nix/store/8zkg9ac4s4alzyf4a8kfrig1j73z66dw-bash-4.4-p23/bin/bash"
checking for references to /tmp/nix-build-rdma-core-19.drv-0 in /nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19...
moving /nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/sbin/* to /nix/store/cgcskv85jpg98fxcjbkhm6s0mlf6k3h8-rdma-core-19/bin

@xeji xeji merged commit a36ab79 into NixOS:master Jul 11, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: rdma-core

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@markuskowa
Copy link
Member Author

@r-ryantm I see, thanks! Maybe we have more luck when 19.1 comes out.

@markuskowa markuskowa deleted the rdma-core-pr branch July 11, 2018 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markuskowa @ryantm @xeji @GrahamcOfBorg