New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hack for common erroneous missing build-tool-depends, and keep duplicate deps for cross #358
Conversation
Also needs: hsx2hs, markdown-unlit. |
@domenkozar OK will do. Any idea what's going on with CI? Seems like a preexisting issue. |
b72d6ac
to
5bbed52
Compare
@Ericson2314 you're hitting #359 |
Thanks! |
0cbb88c
to
66799f0
Compare
@peti You seen this yet? I can fix that CI issue, but it's unrelated to this patch. |
The CI problems are fixed now. |
If we need a library and build tool from the same package, we should keep both deps.
5bbed52
to
5dc763a
Compare
Thanks! rebased and pushed. |
|
See comment in code for more details. Fixes NixOS#356
5dc763a
to
ec494dd
Compare
@domenkozar thanks for fishing that out. Fixed, and ran |
OK cool it built. I guess next step is to revive up strictdeps patch with this while waiting for review? I see the script to regenerate nixpkgs, but not sure what the normal flow (e.g. push to hackage then use that version?) so I'll let @peti do that vs speculatively do in nixpkgs PR. |
The re-generated package set is in |
Now we need to include strictDeps change and reenable all packages since many should build now (mostly macos). @Ericson2314 are you going to re-do that PR? |
This still doesn't add hspec-discover for packages that don't declare it as dependency such as unliftio:
|
I think that's reasonable. |
See comment in code for more details.
The cross change is unambiguously a good thing, and put in the first commit. The
*-discover
hack is more a stop-gap until packages stop being broken---we're not hacking around a Nix deficiency withstrictDeps
here. It relies on the cross change because rather than changing what sort of dependency*-discover
is, it adds a new dependency in case it was actually wanted as a library, which would be removed.Fixes #356
CC @matthewbauer @domenkozar