terraform: describe nixpkgs-tarballs cloudfront #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Jul 11, 2018
terraform/README.md
Outdated
| Then run: | ||
|
|
||
| ``` | ||
| nix-shell --run "terraform apply" |
There was a problem hiding this comment.
Maybe add a note about that this will present a diff and ask if you want to apply it, and that apply won't just go changing things right away.
There was a problem hiding this comment.
Right, I also forgot the terraform init bit
edolstra
reviewed
Jul 11, 2018
| website { | ||
| index_document = "index.html" | ||
| } | ||
| } |
There was a problem hiding this comment.
Note that this bucket is already managed by NixOps.
There was a problem hiding this comment.
What happens if it gets removed from NixOps, will NixOps try to destroy it?
There was a problem hiding this comment.
anyways, I just commented out the declaration for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.